Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avocado validate data-plane readme shouldn't have azure-arm tag #103

Open
tianxchen-ms opened this issue Nov 30, 2022 · 0 comments
Open
Assignees

Comments

@tianxchen-ms
Copy link
Contributor

From: Mike Kistler <[email protected]>

Date: Thursday, April 28, 2022 at 11:16 AM
To: Anne Loomis Thompson <[email protected]>, Shivangi Reja <[email protected]>
Cc: Alexander Sher <[email protected]>
Subject: Re: azure-arm

Anne, Shivangi,

This is good to know! It looks like these files were copy/pasted over from the mgmt plane directory without really understanding what they do or whether they are needed.

With this knowledge, I will start looking for these in API reviews and questioning whether they are needed and whether they should be deleted.

Thanks!

Mike

From: Shivangi Reja <[email protected]>
Date: Wednesday, April 27, 2022 at 10:35 PM
To: Mike Kistler <[email protected]>, Anne Loomis Thompson <[email protected]>
Cc: Alexander Sher <[email protected]>
Subject: RE: azure-arm

Hi @Mike,

We don’t use readme.csharp.md config for any track-2 SDK in azure-sdk-for-net repo. We either use readme.md with tag(ex: autorest.md) or we use directly the swagger file(ex: autorest.md) in autorest.md for all the track-2 SDKs.

Also, we don’t use azure-arm: true flag for any dataplane libraries. This flag is used to generate management plane SDK.

Thanks,

Shivangi

From: Mike Kistler <[email protected]>
Sent: Wednesday, April 27, 2022 7:17 PM
To: Shivangi Reja <[email protected]>; Anne Loomis Thompson <[email protected]>
Subject: Re: azure-arm

I’m asking because I see this flag being used in a number of data-plane services:

Image

Would you agree that these are “bugs” and should be fixed?

Mike

@tianxchen-ms tianxchen-ms self-assigned this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants