Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add improved terraform and bicep workflows #59

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add improved terraform and bicep workflows #59

wants to merge 4 commits into from

Conversation

tjcorr
Copy link
Collaborator

@tjcorr tjcorr commented Aug 24, 2022

TODO:

  • Determine what steps (if any) are required in the workflows besides pointing them at the right working directory. For example to we need to explicitly pass in any parameter files.
  • Add links to the actions.md in both the Terraform and Bicep IAC folders
  • Update a link to the Azure Architecture Center article when published

Closes #42

@tjcorr
Copy link
Collaborator Author

tjcorr commented Aug 25, 2022

I did some testing today trying to get the terraform pipeline to run and ran into a blocker. To use OIDC with the Terraform AzureRM provider you need to be on at least version 3.7.0 (see https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/service_principal_oidc). Unfortunately the CAF module pins AzureRM to 2.88.1 so terraform ends up in a provider conflict. I tried looking at updating the CAF module version but even the newest still doesn't support 3.x. They have supported planned in the future but no expected date (see aztfmod/terraform-azurerm-caf#904).

bahramr
bahramr reviewed Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@bahramr bahramr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjcorr , we have re-organized the structure of the repo. Would it be possible to include the content of your md files into the existing md files? If you like please call me so that we can discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahramr bahramr bahramr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhanced GitHub Actions workflows for Terraform
2 participants
@tjcorr @bahramr