Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSL Passthrough #165

Open
EdSalzedo opened this issue Feb 8, 2024 · 7 comments
Open

Enable SSL Passthrough #165

EdSalzedo opened this issue Feb 8, 2024 · 7 comments

Comments

@EdSalzedo
Copy link

Hi,

I'd like to be able to add --enable-ssl-passthrough as an argument for starting up NGINX. I currently can't find a way of doing it while using the app-routing plugin, would this be possible?

Thanks,

Ed

@OliverMKing
Copy link
Collaborator

OliverMKing commented Feb 9, 2024

Hi @EdSalzedo! Thanks for reaching out.

It's not possible to enable ssl-passthrough globally today but you can enable it through Ingress annotations on individual Ingresses. This is documented here.

We can look into adding a way of configuring this globally to App Routing. Tagging @sabbour so we can add it to the backlog.

Thanks!

@EdSalzedo
Copy link
Author

Hi, thanks for responding @OliverMKing!

I think without -enable-ssl-passthrough flag set on startup, the nginx.ingress.kubernetes.io/ssl-passthrough annotation has no effect based on the testing I've done, although I could have got that wrong.

It'd be useful to be able to configure it at some point so thank you!

@OliverMKing
Copy link
Collaborator

Hi, thanks for responding @OliverMKing!

I think without -enable-ssl-passthrough flag set on startup, the nginx.ingress.kubernetes.io/ssl-passthrough annotation has no effect based on the testing I've done, although I could have got that wrong.

It'd be useful to be able to configure it at some point so thank you!

You are correct! The documentation even says it, which I missed. We will look into this.

@MXClyde
Copy link

MXClyde commented Jun 3, 2024

I also have a use-case that needs this feature so forgive me a +1

@zjylo
Copy link

zjylo commented Jul 2, 2024

Another similar use case is enabling -use-forwarded-headers , we're using Azure Front Door which is setting these values and then getting overwritten by Nginx.

Have to deploy manually for now till this is enabled.

@dinchand
Copy link

dinchand commented Oct 4, 2024

Another similar use case is enabling -use-forwarded-headers , we're using Azure Front Door which is setting these values and then getting overwritten by Nginx.

Have to deploy manually for now till this is enabled.

similar issue for us!

@Soren-Knudsen
Copy link

@zjylo: Can you describe your workaround? We are currently in a similar situation.

Internet -> Azure Frontdoor -> AKS Nginx -> Container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants