Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG TrueFalseInverterScorer has unused threshold, and memory should have a default value of None #464

Open
romanlutz opened this issue Oct 11, 2024 · 0 comments
Open

BUG TrueFalseInverterScorer has unused threshold, and memory should have a default value of None #464

romanlutz opened this issue Oct 11, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@romanlutz
Copy link
Contributor

Describe the bug

PyRIT/pyrit/score/true_false_inverter_scorer.py

Line 15 in ecb51c1

def __init__(self, *, memory: MemoryInterface, scorer: Scorer, threshold: float) -> None:

Scorer doesn't use threshold (so it should be removed) and memory should have a default of None

cc @rlundeen2 please update/correct as needed
@romanlutz romanlutz added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romanlutz