Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predeployment (PrePostDeploymentScript.Ver2.ps1) powershell script stops all blob triggers #467

Open
Bhuard1 opened this issue Nov 7, 2022 · 1 comment

Comments

@Bhuard1
Copy link

Bhuard1 commented Nov 7, 2022

Hi,

I am looking at new release script (ie. PrePostDeploymentScript.Ver2.ps1) that only stop triggers if they have changed

During testing all of the blob event triggers are being stopped even if no code has changed.
The script looks at ArmTemplateParametersForFactory.json currently but it contains values of 'dev' environnements in source control (subscription/ressourcegroup/storeaccount) so when comparing to target environnement differences are seen (variable $additionalPropsChanged is set to True)

Do I need to add another powershell script that would apply the 'override template parameters' in the release onto of the ArmTemplateParametersForFactory.json before running the script that stops the triggers?

Currently we override the ArmTemplateParametersForFactory.json values during the Armtemplate deploiement task with a variable set in 'Override template parameters'

Thanks

@Bhuard1 Bhuard1 changed the title Predeployment powershell script stops all blob triggers Predeployment (PrePostDeploymentScript.Ver2.ps1) powershell script stops all blob triggers Nov 10, 2022
@gvdmaaden
Copy link

gvdmaaden commented Dec 15, 2022

Hi, is there any news on this? We have the same issue: in our AzureResourceGroupDeployment@2 task we provide an ARMTemplateForFactory, an ARMTemplateParametersForFactory and some values for overrideParameters, whereas the PrePostDeploymentScript only supports the ARMTemplate and ArmTemplateParameters as input.
This results in a difference between the template of the deployment step and the powershell step, and thus stopping and starting all of the triggers.
Any chance this will be fixed?

Many thanks and keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants