Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up outdated cache in windows vhd #4981

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: clean up outdated cache in windows vhd #4981

merged 1 commit into from
Sep 20, 2024

Conversation

junjiezhang1997
Copy link
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
clean up outdated cache in windows vhd.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@junjiezhang1997 junjiezhang1997 added windows VHD your change will be included in the following VHDs labels Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10954185311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.271%
Totals Coverage Status
Change from base Build 10954134725: 0.0%
Covered Lines: 2590
Relevant Lines: 3634
💛 - Coveralls

@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/remove-outdated-cache branch from 81b7d6a to ac43836 Compare September 20, 2024 03:16
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/remove-outdated-cache branch from 546ac00 to ac43836 Compare September 20, 2024 05:37
AbelHu
AbelHu approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR

@junjiezhang1997 junjiezhang1997 enabled auto-merge (squash) September 20, 2024 05:52
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/remove-outdated-cache branch from ac43836 to 7ee807f Compare September 20, 2024 06:14
@junjiezhang1997 junjiezhang1997 merged commit 9c421c4 into master Sep 20, 2024
23 checks passed
@junjiezhang1997 junjiezhang1997 deleted the junjiezhang/remove-outdated-cache branch September 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junjiezhang1997 @coveralls @AbelHu