Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add used sidecar images to vhd images #4926

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

andyzhangx
Copy link
Collaborator

@andyzhangx andyzhangx commented Sep 11, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
add used sidecar images to vhd images

this PR is part of revert PR for #4861

livenessprobe: v2.12.0 and csi-node-driver-registrar:v2.10.1 (v2.11.0 is unused now) are still used by aks 1.27, 1.28, add those sidecar images back to vhd images,

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10825831766

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.263%

Totals Coverage Status
Change from base Build 10824127031: 0.0%
Covered Lines: 2589
Relevant Lines: 3633

💛 - Coveralls

Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@andyzhangx andyzhangx enabled auto-merge (squash) September 12, 2024 07:52
@andyzhangx andyzhangx merged commit 8250068 into master Sep 12, 2024
27 checks passed
@andyzhangx andyzhangx deleted the andyzhangx/add-old-images branch September 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants