Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cache cni 1.5.32 in windows #4823

Merged
merged 1 commit into from
Aug 15, 2024
Merged

chore: cache cni 1.5.32 in windows #4823

merged 1 commit into from
Aug 15, 2024

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Aug 15, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Overlooked adding cni installer image on windows in this PR: #4690
This PR adds that image.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

See previous PR linked above for details on cni 1.5.32.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10408207172

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.045%

Totals Coverage Status
Change from base Build 10392437090: 0.0%
Covered Lines: 2569
Relevant Lines: 3616

💛 - Coveralls

@@ -132,6 +132,7 @@ $global:imagesToPull += @(
"mcr.microsoft.com/containernetworking/cni-dropgz:v0.1.4"
"mcr.microsoft.com/containernetworking/cni-dropgz:v0.2.0"
"mcr.microsoft.com/containernetworking/azure-cni:v1.5.26"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming we need to keep 1.5.26 until rollout of 1.5.32 is complete? Please remember to remove 1.5.26 when it becomes possible :)

@QxBytes QxBytes merged commit a523007 into master Aug 15, 2024
42 checks passed
@QxBytes QxBytes deleted the alew/add-cni-1-5-32-win branch August 15, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants