Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade sidecar image versions on node vhd #4547

Merged
merged 2 commits into from
Jul 6, 2024
Merged

feat: upgrade sidecar image versions on node vhd #4547

merged 2 commits into from
Jul 6, 2024

Conversation

andyzhangx
Copy link
Collaborator

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: upgrade sidecar image versions on node vhd

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@andyzhangx andyzhangx added VHD your change will be included in the following VHDs windows labels Jun 24, 2024
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9638866122

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9638714944: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@andyzhangx
Copy link
Collaborator Author

failure is not related to this change:

resources.DeploymentsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidTemplateDeployment" Message="The template deployment 'pkrdppps3wqjdda' is not valid according to the validation procedure. The tracking id is '88601d4f-8e8a-45d6-882a-0a0ebf911c3d'. See inner errors for details." Details=[{"code":"SkuNotAvailable","message":"The requested VM size for resource 'Following SKUs have failed for Capacity Restrictions: Standard_D16ds_v5' is currently not available in location 'eastus'. Please try another size or deploy to a different location or different zone. See https://aka.ms/azureskunotavailable for details."}]

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9655541744

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9653894998: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@andyzhangx andyzhangx enabled auto-merge (squash) June 25, 2024 05:51
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9661537954

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%
Totals Coverage Status
Change from base Build 9659344285: 0.0%
Covered Lines: 2627
Relevant Lines: 3458
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9672230258

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9671901246: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9679268413

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9674880013: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@andyzhangx andyzhangx force-pushed the andyzhangx/upgrade-sidecar-images2 branch from 50003c8 to 4021ac5 Compare June 28, 2024 01:20
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9705933706

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9703459585: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9820320859

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9811870560: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@andyzhangx andyzhangx merged commit 4e32912 into master Jul 6, 2024
25 of 26 checks passed
@andyzhangx andyzhangx deleted the andyzhangx/upgrade-sidecar-images2 branch July 6, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@cameronmeissner cameronmeissner cameronmeissner approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @coveralls @AbelHu @cameronmeissner