Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new API to get cached versions of components on the VHD #4306

Merged
merged 62 commits into from
Apr 26, 2024
Merged

Add new API to get cached versions of components on the VHD #4306

merged 62 commits into from
Apr 26, 2024

Conversation

AlisonB319
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@AlisonB319 AlisonB319 changed the title Alburgess/a bto r pns Add new API to get cached versions of components on the VHD Apr 17, 2024
@coveralls
Copy link

coveralls commented Apr 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8853310931

Details

  • 87 of 112 (77.68%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 79.022%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/agent/bakerapi.go 9 11 81.82%
pkg/agent/datamodel/helper.go 22 26 84.62%
pkg/agent/datamodel/sig_config.go 56 75 74.67%
Totals Coverage Status
Change from base Build 8844632114: -0.05%
Covered Lines: 2554
Relevant Lines: 3232
💛 - Coveralls

@AlisonB319 AlisonB319 marked this pull request as ready for review April 17, 2024 01:25
@AlisonB319 AlisonB319 requested a review from juan-lee as a code owner April 17, 2024 01:25
@AlisonB319 AlisonB319 merged commit 2112126 into master Apr 26, 2024
15 of 16 checks passed
@AlisonB319 AlisonB319 deleted the alburgess/ABtoRPns branch April 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anujmaheshwari1 anujmaheshwari1 anujmaheshwari1 left review comments

@cameronmeissner cameronmeissner cameronmeissner approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlisonB319 @coveralls @cameronmeissner @anujmaheshwari1