Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Rename CustomSearchDomain to CustomSearchDomainConfig #4296

Merged
merged 27 commits into from
Apr 16, 2024
Merged

cleanup: Rename CustomSearchDomain to CustomSearchDomainConfig #4296

merged 27 commits into from
Apr 16, 2024

Conversation

Devinwong
Copy link
Collaborator

@Devinwong Devinwong commented Apr 15, 2024 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Rename CustomSearchDomain to CustomSearchDomainConfig to ensure consistency.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Apr 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8713998566

Details

  • 38 of 52 (73.08%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 79.148%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nbcontracthelper/helper.go 38 52 73.08%
Totals Coverage Status
Change from base Build 8713215760: -0.1%
Covered Lines: 2414
Relevant Lines: 3050
💛 - Coveralls

@Devinwong Devinwong merged commit 1296bd1 into master Apr 16, 2024
16 checks passed
@Devinwong Devinwong deleted the devinwon/CustomSearchDomain branch April 16, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilypan26 lilypan26 lilypan26 approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Devinwong @coveralls @lilypan26