Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: polish NB contract and add more comments #4274

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

Devinwong
Copy link
Collaborator

What type of PR is this?
/kind cleanup
/kind documentation

What this PR does / why we need it:
Polishing the contract and add more comments

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Apr 10, 2024

Pull Request Test Coverage Report for Build 8640868140

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.266%

Totals Coverage Status
Change from base Build 8640820940: 0.0%
Covered Lines: 2355
Relevant Lines: 2971

💛 - Coveralls

@Devinwong Devinwong enabled auto-merge (squash) April 11, 2024 02:59
@Devinwong Devinwong merged commit 448efdd into master Apr 11, 2024
16 checks passed
@Devinwong Devinwong deleted the devinwon/polish_contract branch April 11, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants