Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update CustomCloudConfig proto file #4241

Merged
merged 19 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -208,5 +208,9 @@ ci: bootstrap test-style build test lint
coverage:
@scripts/ginkgo.coverage.sh --codecov

.PHONY: unit-tests
unit-tests:
$(GO) test `go list ./... | grep -v e2e` -coverprofile coverage_raw.out -covermode count

include versioning.mk
include test.mk
21 changes: 1 addition & 20 deletions pkg/parser/utilities.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,6 @@ func getBaseTemplate() *nbcontractv1.Configuration {
}
}

func getBoolStr(state nbcontractv1.FeatureState) string {
if state == nbcontractv1.FeatureState_FEATURE_STATE_ENABLED {
return "true"
}

return "false"
}

func getInverseBoolStr(state nbcontractv1.FeatureState) string {
if state == nbcontractv1.FeatureState_FEATURE_STATE_ENABLED {
return "false"
}

return "true"
}

func getFuncMap() template.FuncMap {
return template.FuncMap{
"getBoolStr": getBoolStr,
"getInverseBoolStr": getInverseBoolStr,
}
return template.FuncMap{}
}
58 changes: 27 additions & 31 deletions pkg/proto/nbcontract/v1/apiserverconfig.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions pkg/proto/nbcontract/v1/apiserverconfig.proto
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
syntax = "proto3";
package nbcontract.v1;
import "pkg/proto/nbcontract/v1/featurestate.proto";

message ApiServerConfig {
string apiserver_public_key = 1;
string apiserver_name = 2;
string api_server_public_key = 1;
string api_server_name = 2;
}
Loading
Loading