Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up unused Get-KubeBinaries and unused rule in windows e2e yaml #4004

Merged
merged 4 commits into from
Jan 26, 2024
Merged

chore: clean up unused Get-KubeBinaries and unused rule in windows e2e yaml #4004

merged 4 commits into from
Jan 26, 2024

Conversation

junjiezhang1997
Copy link
Collaborator

@junjiezhang1997 junjiezhang1997 commented Jan 26, 2024 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  1. clean up unused Get-KubeBinaries.
  2. clean up unused rule in windows e2e yaml.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Jan 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7665135093

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.313%
Totals Coverage Status
Change from base Build 7664310292: 0.0%
Covered Lines: 2285
Relevant Lines: 2881
💛 - Coveralls

AbelHu
AbelHu approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@junjiezhang1997 junjiezhang1997 changed the title chore: clean up unusedGet-KubeBinaries chore: clean up unused Get-KubeBinaries and unused rules in windows e2e yaml Jan 26, 2024
@junjiezhang1997 junjiezhang1997 changed the title chore: clean up unused Get-KubeBinaries and unused rules in windows e2e yaml chore: clean up unused Get-KubeBinaries and unused rule in windows e2e yaml Jan 26, 2024
@junjiezhang1997 junjiezhang1997 force-pushed the junjiezhang/remove-unused-get-kubebinaries branch from 6b716ab to 38fb1e8 Compare January 26, 2024 07:11
@junjiezhang1997 junjiezhang1997 merged commit 89516f2 into master Jan 26, 2024
31 of 32 checks passed
@junjiezhang1997 junjiezhang1997 deleted the junjiezhang/remove-unused-get-kubebinaries branch January 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

Assignees
No one assigned
Labels
build windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junjiezhang1997 @coveralls @AbelHu