Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AKS Log Collector to VHD #3991

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Conversation

phealy
Copy link
Collaborator

@phealy phealy commented Jan 23, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds the new AKS Log Collector script into the VHD to take over uploading log bundles until WALA adds support for cgroups v2.
 
Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7669278849

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.313%

Totals Coverage Status
Change from base Build 7665266804: 0.0%
Covered Lines: 2285
Relevant Lines: 2881

💛 - Coveralls

@cameronmeissner
Copy link
Collaborator

cameronmeissner commented Jan 23, 2024

do we still need the previous change you had to modify the upload_logs func within cse_start.sh?

@phealy
Copy link
Collaborator Author

phealy commented Jan 23, 2024

do we still need the previous change you had to modify the upload_logs func within cse_start.sh?

Yes, and I forgot that. Will fix tomorrow!

@phealy phealy changed the title Pahealy/aks log collector vhd feat: add AKS Log Collector to VHD Jan 25, 2024
@phealy phealy enabled auto-merge (squash) January 25, 2024 18:57
@phealy phealy merged commit 6335635 into master Jan 26, 2024
19 of 20 checks passed
@phealy phealy deleted the pahealy/aks-log-collector-vhd branch January 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants