Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return error details in Windows CSE #3931

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

AbelHu
Copy link
Member

@AbelHu AbelHu commented Dec 14, 2023

What type of PR is this?

What this PR does / why we need it:
Return error details in Windows CSE. This change will be vendored after Windows CSE version is updated to v1.10.

  • Test logs with long message:
Code="VMExtensionProvisioningError" Message="VM has reported a failure when processing extension 'vmssCSE' (publisher 'Microsoft.Compute' and type 'CustomScriptExtension'). Error message: \"Command execution finished, but failed because it returned a non-zero exit code of: '1'. The command had an error output of: 'ExitCode: |34|, Output: |WINDOWS_CSE_ERROR_DOWNLOAD_KUBERNETES_PACKAGE|, Error: |Failed in downloading \r\nhttps://acs-mirror.azureedge.net/kubernetes/v1.25.15-hotfix.20231103/windowszip/v1.25.15-hotfix.20231111-1int.zip. \r\nError: BlobNotFoundTh|\r\nAt C:\\Azur...' For more information, check the instance view by executing Get-AzVmssVm or Get-AzVm (https://aka.ms/GetAzVm). These commands can be executed using CloudShell ([https://aka.ms/CloudShell)\](https://aka.ms/CloudShell)/)\". More information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot." Target="5"', no response
  • Test logs with short message:
Code="VMExtensionProvisioningError" Message="VM has reported a failure when processing extension 'vmssCSE' (publisher 'Microsoft.Compute' and type 'CustomScriptExtension'). Error message: \"Command execution finished, but failed because it returned a non-zero exit code of: '1'. The command had an error output of: 'ExitCode: |34|, Output: |WINDOWS_CSE_ERROR_DOWNLOAD_KUBERNETES_PACKAGE|, Error: |Failed in downloading fakeurl. Error: \r\nThe remote name could not be resolved: 'fakeurl'|\r\nAt C:\\AzureData\\CustomDataSetupScript.ps1:523 char:9\r\n+         throw \"ExitCode: |$g...' For more information, check the instance view by executing Get-AzVmssVm or Get-AzVm (https://aka.ms/GetAzVm). These commands can be executed using CloudShell ([https://aka.ms/CloudShell)\](https://aka.ms/CloudShell)/)\". More information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot. " Target="4"', no response

  • Test logs without customdata.bin:
Code="VMExtensionProvisioningError" Message="VM has reported a failure when processing extension 'vmssCSE' (publisher 'Microsoft.Compute' and type 'CustomScriptExtension'). Error message: \"Command execution finished, but failed because it returned a non-zero exit code of: '1'. The command had an error output of: 'ExitCode: |49|, Output: |WINDOWS_CSE_ERROR_NO_CUSTOM_DATA_BIN|, Error: |C:\\AzureData\\CustomData.bin does not exist.|\r\nAt line:1 char:2886\r\n+ ... putFile)) { throw 'ExitCode: |49|, Output: |WINDOWS_CSE_ERROR_NO_CUST ...\r\n+                 ~~~~~~~~~~~~~~~~~~...' For more information, check the instance view by executing Get-AzVmssVm or Get-AzVm (https://aka.ms/GetAzVm). These commands can be executed using CloudShell ([https://aka.ms/CloudShell)\](https://aka.ms/CloudShell)/)\". More information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot. " Target="4"', no response

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7957858925

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.313%

Totals Coverage Status
Change from base Build 7954566081: 0.0%
Covered Lines: 2285
Relevant Lines: 2881

💛 - Coveralls

@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 3322ab1 to 729e83c Compare December 14, 2023 14:02
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 729e83c to 633fafa Compare December 14, 2023 14:12
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch 2 times, most recently from 17c0960 to 664bf85 Compare December 15, 2023 03:13
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 664bf85 to 71e8788 Compare December 15, 2023 05:25
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 71e8788 to 0fc4937 Compare December 15, 2023 08:58
@AbelHu AbelHu marked this pull request as ready for review December 18, 2023 01:19
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch 2 times, most recently from 8e43138 to 18e37aa Compare January 16, 2024 01:10
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 18e37aa to de8a954 Compare January 19, 2024 05:47
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from de8a954 to 19b9a3b Compare January 19, 2024 06:03
@thomas1206
Copy link

LGTM.

@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 19b9a3b to d1d4de5 Compare January 26, 2024 06:13
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from 5c57658 to a25b548 Compare February 19, 2024 08:10
@AbelHu AbelHu enabled auto-merge (squash) February 19, 2024 08:25
@AbelHu AbelHu force-pushed the abelch/return-error-message-in-win-cse branch from a25b548 to 7f1e746 Compare February 19, 2024 10:10
@AbelHu AbelHu merged commit 75004e9 into master Feb 19, 2024
31 of 32 checks passed
@AbelHu AbelHu deleted the abelch/return-error-message-in-win-cse branch February 19, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants