Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server and (sometimes) Client Entra ID apps get renamed if using manual setup #2230

Open
corrreia opened this issue Dec 12, 2024 · 1 comment
Labels
auth bug Something isn't working

Comments

@corrreia
Copy link

corrreia commented Dec 12, 2024

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Use the manual setup guide to create Entra ID apps for server and client.

Any log messages given by the failure

no

Expected/desired behavior

If apps are manually created the names of the apps should not get changed every time azd deploy is ran

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
win 10

azd version?

run azd version and copy paste here.
azd version 1.11.0

Versions

Mention any other details that might be useful

maybe this line: await graph_client.applications.by_application_id(object_id).patch(request_app) on auth_init.py should not exist.

image


Thanks! We'll be in touch soon.

@corrreia corrreia changed the title Server and (sometimes) Client Entra ID Server and (sometimes) Client Entra ID apps get renamed if using manual setup Dec 12, 2024
@pamelafox pamelafox added the auth label Dec 12, 2024
@pamelafox
Copy link
Collaborator

Ah I see, because we generate random_app_identifier each time. That's a good point. I don't recall offhand why we had the patch, if that was only in case the configuration had changed over time. But we could also query the name for an existing app to avoid renaming.

cc @mattgotteiner

@pamelafox pamelafox added the bug Something isn't working label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants