Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cosmos Bicep configuration #2226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pamelafox
Copy link
Collaborator

Purpose

Fixes #2217

Changes the cosmos private endpoint from 'cosmosdb' to 'sql', which is the correct subresource based on https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-dns#databases

Once again, I don't yet have a VNET test deployment in my current tenant, so I have not verified personally. This fix was recommended by the developer who filed #2217.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No

Type of change

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private link config for cosmos DB should be set to "sql" and not "cosmosdb" for private appservice deployments
1 participant