Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map string settings to appropriate types #11

Open
hsimah opened this issue Jun 12, 2019 · 0 comments
Open

Map string settings to appropriate types #11

hsimah opened this issue Jun 12, 2019 · 0 comments
Assignees
@justlevine
Labels
status: confirmed 📍 The issue has been confirmed and reproduced. type: enhancement ⚡ Improves on an existing feature
Milestone
Future

Comments

@hsimah
Copy link
Collaborator

hsimah commented Jun 12, 2019

FacetWP sends through 'yes' and 'no' for some settings. These really should be boolean values on the consumer end. Check other settings for similar issues.
@justlevine justlevine added status: confirmed 📍 The issue has been confirmed and reproduced. type: enhancement ⚡ Improves on an existing feature and removed help wanted labels Jul 23, 2022
@justlevine justlevine added this to the v0.4.0 milestone Jul 23, 2022
@justlevine justlevine self-assigned this Jul 23, 2022
@justlevine justlevine modified the milestones: v0.4.0, Future Jan 12, 2023
This was referenced Jan 15, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justlevine justlevine

Labels
status: confirmed 📍 The issue has been confirmed and reproduced. type: enhancement ⚡ Improves on an existing feature
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@hsimah @justlevine