Donations

[csmuller]

The GrantShares dApp currently intends that only funding sent to the treasury can be spent on project proposals and only whitelisted funders can send tokens to the treasury. @steven1227 brought up the idea to extend this with donations that can made by anyone.

Here's two ways in which such a feature can implemented:

1. Add a donation feature only to the GrantShares web page. This feature would allow users to choose a project proposal from the list and click a donate button. The web page extracts the receiver address from the proposal's intents and lets the user choose a donation amount. From all this info it constructs a transaction and manages signing and sending it through a wallet (e.g., NeoLine).
   This works only for project proposals. Only they have a receiver address in their intents to which the donation can be sent. Instead of sending donation to the receiver mentioned in a proposal's intents, they could also be sent to the proposer directly (that information is connected to the proposal).

2. Integrate the donation feature into the GrantShares contracts. In this scenario each proposal has a donations balance. Users can choose a proposal and donate tokens to it, but, the donations collected by a proposal are not released to the proposer until the proposal is successfully executed. Thus, the donations are conceptualised as a part of the funding released by a project proposal. The most effortful part of this solution is, the bookkeeping that the contracts have to do on the donations. If a proposal is not accepted, the donations on it have to be sent back to their respective owners. A much easier solution would be to only allow donations on already accepted/executed proposals (no bookkeeping necessary).