Improve Compositor.json

[Sammy99jsp]

As suggested by @dorakuflu
I'll quote the their example Compositor.json here as it is good idea.

I'll also add a couple more suggestions:

• Make variables more distinguishable from plaintext by using some sort of syntax (e.g. %mod%, {{mod}}, $mod)
• Make Compositor.json a .jsonc file to allow comments.

{
	"variables": {
		"mod": "Mod4",
		"term": "avdanterm",
		"browser": "firefox"
	},
	"tiling": {
		"keybinds": {
			"openTerm": "mod+Enter",
			"openBrowser": "mod+b",
			"closeWindow": "mod+q",
			"reloadConfig": "mod+Shift+c",
			"shutdownPanel": "mod+Shift+s",
			"moveFocusLeft": "mod+Left",
			"moveFocusRight": "mod+Right",
			"moveFocusUp": "mod+Up",
			"moveFocusDown": "mod+Down",
			"moveWindowLeft": "mod+Shift+Left",
			"moveWindowRight": "mod+Shift+Right",
			"moveWindowUp": "mod+Shift+Up",
			"moveWindowDown": "mod+Shift+Down",
			"workspace1": "mod+1",
			"workspace2": "mod+2",
			"workspace3": "mod+3",
			"workspace4": "mod+4",
			"moveWindowWorkspace1": "mod+Shift+1",
			"moveWindowWorkspace2": "mod+Shift+2",
			"moveWindowWorkspace3": "mod+Shift+3",
			"moveWindowWorkspace4": "mod+Shift+4",
			"splitVertically": "mod+v",
			"splitHorizontally": "mod+h",
			"fullscreen": "mod+f",
			"switchModes": "mod+Shift+Space",
			"resizeLeft": "mod+r+Left",
			"resizeRight": "mod+r+Right",
			"resizeUp": "mod+r+Up",
			"resizeDown": "mod+r+Down"
		}
	}
}

[Sammy99jsp]

For example, for the workspace keybinds, we could do something like:

{
    /* ... */
    "workspace(n)": "{mod}+{n}",
    "moveWindowWorkspace(n)": "{mod}+{n}",
    /* ... */
}

[dorakuflu]

For example, for the workspace keybinds, we could do something like:

{
    /* ... */
    "workspace(n)": "{mod}+{n}",
    "moveWindowWorkspace(n)": "{mod}+{n}",
    /* ... */
}

Just took a look at your pr, very nice work on the compositor! I'm just curious how we could define the {n} variable here (since it can have more than one value at a time). Also, did you use brackets to specifiy that the value inside is a variable, or did you use them to to specify that the variable inside can have multiple values (like n can be 1,2,3...).

[Sammy99jsp]

Hey, sorry I didn't see this!

Just took a look at your pr, very nice work on the compositor!

First of all, thanks!
I'll probably be spending most of the next couple days on getting the functionalities me and you have suggested working.

I'm just curious how we could define the {n} variable here (since it can have more than one value at a time). Also, did you use brackets to specify that the value inside is a variable, or did you use them to to specify that the variable inside can have multiple values (like n can be 1,2,3...).

I was thinking something similar to macros, so I guess, kind of both options.
The brackets are there to show that any variables belong to the macro itself (and in this case, means that the value of n does change). In the event that there was a global variable called n, I would imagine that its value would be overridden.

[Sammy99jsp]

I'll actually re-open this issue since there's a few other things around the configuration that can still be up for discussion (and so I can get Discord notifications, lol).

[Sammy99jsp]

What would be cool to see are error (or warning messages) with line and column numbers.
Although with serde, this can prove quite... difficult to say the least.

[Kibalchish47]

So speaking of the MoveWindowLeft and the other MoveWindow ones, we can make a standard chunk, say 50 pixels, and using the keyboard shortcut the window will get smaller and smaller by this definite amount (here it's 50 px). Thus, it can be changed in the config file