Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Avalonia 11.1? #48

Closed
Numpsy opened this issue Apr 5, 2024 · 3 comments · Fixed by #49
Closed

Compatibility with Avalonia 11.1? #48

Numpsy opened this issue Apr 5, 2024 · 3 comments · Fixed by #49
Labels
bug Something isn't working

Comments

@Numpsy
Copy link

Numpsy commented Apr 5, 2024

Hi,

While testing with danipen/TextMateSharp#57 (comment) in the Avalonia 11.1 previews, I noticed that an about box using DialogHost.Avalonia didn't work correctly - the dialog appeared but didn't disappear when closed, just hung about over the top of the background.

As a test I tried updating the demo application from this repository to the Avalonia 11.1 Beta 1 release and saw there are problems there as well
dh

There are also some warnings in the debugger output:

[Binding]An error occurred binding 'OverlayBackground' to '': 'Could not convert 'DialogHostDemo.ViewModels.MainWindowViewModel' (DialogHostDemo.ViewModels.MainWindowViewModel) to 'Avalonia.Media.IBrush'.' (DialogHost #25747420)
[Binding]An error occurred binding 'Background' to '': 'Could not convert 'DialogHostDemo.ViewModels.MainWindowViewModel' (DialogHostDemo.ViewModels.MainWindowViewModel) to 'Avalonia.Media.IBrush'.' (DialogHost #25747420)

Thanks.

@SKProCH SKProCH added the bug Something isn't working label Apr 5, 2024
@SKProCH
Copy link
Member

SKProCH commented Apr 7, 2024

So, currently seems like my custom binding for getting colors from different themes doesn't work with updated binding system from avalonia 11.1.

As for workaround you can set values to this properties (Background, OverlayBackground) by youself.

I've currently trying to figure out how to adapt to new avalonia binding system.

@SKProCH
Copy link
Member

SKProCH commented Apr 10, 2024

Details can found here: AvaloniaUI/Avalonia#15270

@Numpsy
Copy link
Author

Numpsy commented Apr 12, 2024

Thanks, my own application is working now with the new update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants