Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Decoupled timer_start from Gui to avoid circular dependencies #2392

Closed
2 of 4 tasks
The1W2c opened this issue Jan 11, 2025 · 6 comments
Closed
2 of 4 tasks

Fix: Decoupled timer_start from Gui to avoid circular dependencies #2392

The1W2c opened this issue Jan 11, 2025 · 6 comments
Labels
📈 Improvement Improvement of a feature.

Comments

@The1W2c
Copy link

The1W2c commented Jan 11, 2025

Description

This PR refactors timer_start to accept callbacks instead of directly interacting with Taipy's GUI, resolving circular dependency issues. It also includes tests and documentation updates.

Acceptance Criteria

  • Any new code is covered by a unit tested.
  • Check code coverage is at least 90%.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@The1W2c The1W2c added the 📈 Improvement Improvement of a feature. label Jan 11, 2025
@FlorianJacta
Copy link
Member

I am not sure to understand your issue. Could you be more explicit? What kind of issues did you face?

@The1W2c
Copy link
Author

The1W2c commented Jan 13, 2025

The PR refactors timer_start to accept callbacks instead of directly interacting with Taipy's GUI to resolve circular dependency issues. Circular dependencies occur when modules depend on each other, leading to tight coupling and potential runtime errors. By introducing callbacks, the refactor decouples the timer logic from the GUI, adhering to principles like separation of concerns and dependency injection. This approach improves code maintainability and reduces the risk of errors caused by circular imports, which are common in poorly organized codebases

@jrobinAV
Copy link
Member

This is not a proper issue. I suspect a bot created issue.

@The1W2c
Copy link
Author

The1W2c commented Jan 13, 2025 via email

@jrobinAV
Copy link
Member

@The1W2c
Sure, no problem.

An issue is made to propose a new feature, propose an improvement or a change, or report a bug. The issue description should contain all the information needed to understand what is proposed. For example, it could contain:

  • a description of the bug or the functionality
  • the motivation
  • a real or realistic use case
  • some examples
  • a description of the possible impacts
  • a list of acceptance criteria

Once an issue is created, the Taipy maintainers team needs to review and qualify the issue to validate, improve, or reject it.

Once an issue is validated, internal or external contributors can be assigned. Contributors can make the changes on their own clones and create a PR (pull request) to propose merging their changes into Taipy. Taipy maintainers have to review and approve the PR so it can be merged.

@The1W2c
Copy link
Author

The1W2c commented Jan 14, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Improvement Improvement of a feature.
Projects
None yet
Development

No branches or pull requests

3 participants