-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Decoupled timer_start from Gui to avoid circular dependencies #2392
Comments
I am not sure to understand your issue. Could you be more explicit? What kind of issues did you face? |
The PR refactors timer_start to accept callbacks instead of directly interacting with Taipy's GUI to resolve circular dependency issues. Circular dependencies occur when modules depend on each other, leading to tight coupling and potential runtime errors. By introducing callbacks, the refactor decouples the timer logic from the GUI, adhering to principles like separation of concerns and dependency injection. This approach improves code maintainability and reduces the risk of errors caused by circular imports, which are common in poorly organized codebases |
This is not a proper issue. I suspect a bot created issue. |
To be honest, im just now learning coding and trying to figure it out. So
yeah I did ask an AI to give me a good contribution that I could make to
Avaiga/taipy. Im assuming that putting it as an issue is the wrong way? Any
help or advice would be greatly appreciated. Thanks
…On Mon, Jan 13, 2025, 12:36 PM Jean-Robin ***@***.***> wrote:
This is not a proper issue. I suspect a bot created issue.
—
Reply to this email directly, view it on GitHub
<#2392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMK5B3ITUVPDHN2QZQJ5TSL2KP2STAVCNFSM6AAAAABVAAJX3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXG42TONBUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@The1W2c An issue is made to propose a new feature, propose an improvement or a change, or report a bug. The issue description should contain all the information needed to understand what is proposed. For example, it could contain:
Once an issue is created, the Taipy maintainers team needs to review and qualify the issue to validate, improve, or reject it. Once an issue is validated, internal or external contributors can be assigned. Contributors can make the changes on their own clones and create a PR (pull request) to propose merging their changes into Taipy. Taipy maintainers have to review and approve the PR so it can be merged. |
Now I understand, thanks for the advice, I really do appreciate it.
…On Tue, Jan 14, 2025, 5:25 AM Jean-Robin ***@***.***> wrote:
@The1W2c <https://github.com/The1W2c>
Sure, no problem.
An issue is made to propose a new feature, propose an improvement or a
change, or report a bug. The issue description should contain all the
information needed to understand what is proposed. For example, it could
contain:
- a description of the bug or the functionality
- the motivation
- a real or realistic use case
- some examples
- a description of the possible impacts
- a list of acceptance criteria
Once an issue is created, the Taipy maintainers team needs to review and
qualify the issue to validate, improve, or reject it.
Once an issue is validated, internal or external contributors can be
assigned. Contributors can make the changes on their own clones and create
a PR (pull request) to propose merging their changes into Taipy. Taipy
maintainers have to review and approve the PR so it can be merged.
—
Reply to this email directly, view it on GitHub
<#2392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMK5B3JZ4CGIE367TKWQJ5L2KTQYRAVCNFSM6AAAAABVAAJX3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBZGU2DAMRXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
This PR refactors timer_start to accept callbacks instead of directly interacting with Taipy's GUI, resolving circular dependency issues. It also includes tests and documentation updates.
Acceptance Criteria
Code of Conduct
The text was updated successfully, but these errors were encountered: