Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master Bar: Add Launch Button #98918

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Master Bar: Add Launch Button #98918

wants to merge 1 commit into from
+27 −0

Conversation

youknowriad
Copy link
Contributor

closes #98903

Proposed Changes

This PR adds a "launch button" to the Calypso master bar. We're adding a similar button to the admin bar (frontend, wp-admin and atomic). For consistency, we're adding it to Calypso's master bar as well.

Testing Instructions

  • Open the admin (default style, not classic style) of an unlaunched site.
  • Notice the "launch button" in the master bar.
  • Click the button to launch the site.

@youknowriad youknowriad added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jan 25, 2025
@youknowriad youknowriad self-assigned this Jan 25, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131074
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131074&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131074&env=a8c-for-agencies

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/launch-button on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~7856 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-login               +27121 B  (+1.3%)    +7926 B  (+1.3%)
entry-main                +26370 B  (+1.2%)    +7735 B  (+1.4%)
entry-domains-landing       -330 B  (-0.0%)      -56 B  (-0.0%)
entry-browsehappy           -330 B  (-0.2%)      -56 B  (-0.1%)
entry-subscriptions         -172 B  (-0.0%)      -43 B  (-0.0%)
entry-stepper                +36 B  (+0.0%)       -8 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~61086 bytes removed 📉 [gzipped])

name                                parsed_size           gzip_size
hosting                                -27911 B  (-1.0%)    -7659 B  (-1.0%)
theme                                  -27265 B  (-3.4%)    -8470 B  (-3.4%)
themes                                 -27199 B  (-2.7%)    -8054 B  (-2.6%)
settings-performance                   -26960 B  (-4.9%)    -7704 B  (-4.5%)
sites-dashboard                        -26912 B  (-2.2%)    -7999 B  (-2.3%)
site-performance                       -26912 B  (-1.7%)    -7891 B  (-1.8%)
github-deployments                     -26912 B  (-1.9%)    -7886 B  (-2.0%)
jetpack-cloud-plugin-management        -26903 B  (-1.1%)    -8896 B  (-1.3%)
a8c-for-agencies-plugins               -26903 B  (-1.2%)    -8917 B  (-1.4%)
site-overview                          -26899 B  (-1.7%)    -7867 B  (-1.7%)
site-marketing                         -26887 B  (-1.7%)    -7920 B  (-1.8%)
plugins                                -26877 B  (-0.8%)    -8896 B  (-1.0%)
staging-site                           -26874 B  (-1.7%)    -7976 B  (-1.8%)
site-tools                             -26874 B  (-1.6%)    -7975 B  (-1.6%)
site-monitoring                        -26874 B  (-2.0%)    -8021 B  (-2.1%)
site-logs                              -26874 B  (-1.9%)    -7951 B  (-2.0%)
hosting-features                       -26874 B  (-2.1%)    -8004 B  (-2.2%)
site-settings                          -26861 B  (-1.7%)    -7990 B  (-1.8%)
home                                   -26861 B  (-1.6%)    -7654 B  (-1.6%)
settings                               -26848 B  (-2.5%)    -7572 B  (-2.4%)
marketplace                            -21341 B  (-2.3%)    -6819 B  (-2.4%)
a8c-for-agencies-sites                 -21184 B  (-0.9%)    -5759 B  (-0.9%)
scan                                   -21158 B  (-2.4%)    -5786 B  (-2.3%)
backup                                 -21158 B  (-1.7%)    -5773 B  (-1.7%)
woocommerce-installation               -20079 B  (-5.7%)    -6115 B  (-5.5%)
marketing                              -15074 B  (-1.7%)    -4489 B  (-1.7%)
plans                                  -14505 B  (-1.0%)    -4205 B  (-1.0%)
activity                               -14422 B  (-1.8%)    -3983 B  (-1.8%)
preview                                -13421 B  (-4.5%)    -3754 B  (-4.0%)
checkout                               -12133 B  (-0.7%)    -3151 B  (-0.6%)
comments                               -11600 B  (-1.5%)    -2968 B  (-1.4%)
domains                                -11558 B  (-0.5%)    -2210 B  (-0.4%)
customize                              -11349 B  (-3.5%)    -2881 B  (-2.9%)
settings-security                      -11311 B  (-2.3%)    -2884 B  (-1.9%)
jetpack-search                         -11311 B  (-1.9%)    -2889 B  (-1.7%)
jetpack-cloud-settings                 -11311 B  (-1.5%)    -2882 B  (-1.3%)
settings-podcast                       -11245 B  (-2.2%)    -2927 B  (-1.9%)
settings-writing                       -11034 B  (-1.8%)    -2851 B  (-1.7%)
settings-reading                       -11034 B  (-2.5%)    -2750 B  (-2.1%)
settings-newsletter                    -11034 B  (-2.0%)    -2851 B  (-1.8%)
settings-discussion                    -11034 B  (-2.7%)    -2818 B  (-2.3%)
people                                 -11034 B  (-1.3%)    -2817 B  (-1.1%)
site-purchases                         -10887 B  (-0.5%)    -2755 B  (-0.4%)
purchases                              -10887 B  (-0.4%)    -2749 B  (-0.4%)
stats                                  -10637 B  (-0.9%)    -2691 B  (-0.8%)
jetpack-connect                        -10270 B  (-0.9%)    -2563 B  (-0.7%)
email                                  -10103 B  (-1.3%)    -2586 B  (-1.1%)
promote-post-i2                        -10064 B  (-1.3%)    -2458 B  (-1.0%)
settings-jetpack                       -10052 B  (-1.8%)    -2508 B  (-1.5%)
notification-settings                  -10052 B  (-1.4%)    -2517 B  (-1.2%)
media                                  -10052 B  (-0.6%)    -2513 B  (-0.6%)
gutenberg-editor                       -10052 B  (-1.7%)    -2518 B  (-1.4%)
export                                 -10052 B  (-3.0%)    -2499 B  (-2.4%)
concierge                              -10052 B  (-2.0%)    -2509 B  (-1.8%)
account                                -10052 B  (-1.3%)    -2513 B  (-1.1%)
posts-custom                            -9993 B  (-1.4%)    -2462 B  (-1.1%)
posts                                   -9993 B  (-1.4%)    -2462 B  (-1.1%)
migrate                                 -9993 B  (-2.5%)    -2471 B  (-2.1%)
import                                  -9949 B  (-1.3%)    -2481 B  (-1.0%)
site-blocks                             -9862 B  (-1.7%)    -2470 B  (-1.4%)
security                                -9862 B  (-1.2%)    -2454 B  (-1.0%)
privacy                                 -9862 B  (-1.7%)    -2461 B  (-1.5%)
me                                      -9862 B  (-1.8%)    -2466 B  (-1.5%)
help                                    -9862 B  (-1.7%)    -2465 B  (-1.4%)
developer                               -9862 B  (-1.7%)    -2470 B  (-1.4%)
account-close                           -9862 B  (-1.7%)    -2470 B  (-1.5%)
woocommerce                             -9775 B  (-3.1%)    -2422 B  (-2.5%)
subscribers                             -9775 B  (-0.7%)    -2422 B  (-0.7%)
pages                                   -9775 B  (-2.0%)    -2424 B  (-1.6%)
jetpack-social                          -9775 B  (-1.4%)    -2422 B  (-1.2%)
jetpack-cloud-pricing                   -9775 B  (-1.2%)    -2422 B  (-1.0%)
jetpack-cloud-overview                  -9775 B  (-2.1%)    -2367 B  (-1.7%)
jetpack-cloud-features-comparison       -9775 B  (-1.4%)    -2422 B  (-1.2%)
jetpack-cloud                           -9775 B  (-2.4%)    -2422 B  (-1.9%)
google-my-business                      -9775 B  (-2.0%)    -2422 B  (-1.6%)
earn                                    -9775 B  (-1.2%)    -2424 B  (-1.0%)
add-ons                                 -9775 B  (-2.8%)    -2422 B  (-2.2%)
jetpack-cloud-partner-portal            -1981 B  (-0.2%)     -469 B  (-0.2%)
a8c-for-agencies-referrals              -1791 B  (-0.2%)     -500 B  (-0.2%)
reader                                  -1692 B  (-0.1%)     -356 B  (-0.1%)
jetpack-cloud-agency-dashboard          -1680 B  (-0.2%)     -355 B  (-0.1%)
link-in-bio-tld-flow                    +1304 B  (+0.1%)     -779 B  (-0.1%)
update-design-flow                       -647 B  (-0.0%)     -362 B  (-0.1%)
patterns                                 -591 B  (-0.0%)     -250 B  (-0.0%)
incoming-redirect                        -578 B  (-2.4%)     -197 B  (-2.3%)
a8c-for-agencies-team                    -578 B  (-0.1%)     -235 B  (-0.1%)
a8c-for-agencies-signup                  -578 B  (-0.4%)     -238 B  (-0.6%)
a8c-for-agencies-settings                -578 B  (-0.3%)     -238 B  (-0.4%)
a8c-for-agencies-purchases               -578 B  (-0.1%)     -241 B  (-0.1%)
a8c-for-agencies-partner-directory       -578 B  (-0.1%)     -179 B  (-0.1%)
a8c-for-agencies-overview                -578 B  (-0.1%)     -235 B  (-0.1%)
a8c-for-agencies-migrations              -578 B  (-0.1%)     -235 B  (-0.1%)
a8c-for-agencies-marketplace             -578 B  (-0.1%)     -241 B  (-0.1%)
a8c-for-agencies-client                  -578 B  (-0.0%)     -235 B  (-0.1%)
a8c-for-agencies-agency-tier             -578 B  (-0.2%)     -236 B  (-0.3%)
start-writing-flow                       +260 B  (+0.7%)      +60 B  (+0.7%)
site-setup-wg                            +234 B  (+0.1%)      +30 B  (+0.0%)
site-setup-flow                          +234 B  (+0.1%)      +30 B  (+0.0%)
transferring-hosted-site-flow            +230 B  (+0.1%)     -429 B  (-0.5%)
signup                                   -220 B  (-0.1%)     -226 B  (-0.3%)
jetpack-app                              -218 B  (-0.1%)      -37 B  (-0.0%)
hundred-year-plan                        +174 B  (+0.1%)      +39 B  (+0.1%)
import-hosted-site-flow                  -164 B  (-0.0%)     +509 B  (+0.1%)
design-first-flow                        +152 B  (+0.4%)      +52 B  (+0.6%)
write-flow                               -120 B  (-0.0%)     +364 B  (+0.1%)
build-flow                               -120 B  (-0.0%)     +365 B  (+0.1%)
newsletter-flow                          +109 B  (+0.3%)      +33 B  (+0.4%)
onboarding-flow                          -108 B  (-0.4%)      -29 B  (-0.4%)
new-hosted-site-flow-user-included       -108 B  (-0.1%)      -31 B  (-0.1%)
new-hosted-site-flow                     -108 B  (-0.1%)       -1 B  (-0.0%)
newsletter-post-setup-flow                +66 B  (+0.0%)      +11 B  (+0.0%)
link-in-bio-post-setup-flow               +66 B  (+0.0%)      +11 B  (+0.0%)
hundred-year-domain                       +66 B  (+0.0%)      +14 B  (+0.0%)
example-flow                              +66 B  (+0.3%)      +12 B  (+0.2%)
copy-site-flow                            +52 B  (+0.0%)      +39 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~17871 bytes removed 📉 [gzipped])

name                                                                              parsed_size            gzip_size
async-load-calypso-components-web-preview-component                                  -17086 B   (-3.9%)    -5516 B   (-4.2%)
async-load-design-playground                                                          -9335 B   (-0.7%)    -2147 B   (-0.6%)
async-load-design                                                                     -9335 B   (-0.6%)    -2134 B   (-0.5%)
async-load-calypso-reader-sidebar                                                     -8372 B   (-8.0%)    -2122 B   (-7.4%)
async-load-calypso-layout-guided-tours-component                                      -7794 B  (-12.7%)    -1802 B  (-10.8%)
async-load-design-blocks                                                              -3446 B   (-0.2%)     -956 B   (-0.2%)
async-load-calypso-blocks-calendar-popover                                            -1284 B   (-0.5%)     -463 B   (-0.8%)
async-load-calypso-my-sites-checkout-modal                                             +280 B   (+0.0%)     -459 B   (-0.1%)
async-load-calypso-layout-command-palette                                              -277 B   (-0.1%)      -81 B   (-0.1%)
async-load-calypso-blocks-app-banner                                                   -277 B   (-0.1%)      -90 B   (-0.2%)
async-load-automattic-search                                                           +206 B   (+0.6%)      +54 B   (+0.5%)
async-load-signup-steps-site-picker                                                    +196 B   (+0.1%)     +556 B   (+0.7%)
async-load-signup-steps-difm-site-picker                                               +196 B   (+0.1%)     +542 B   (+0.7%)
async-load-signup-steps-design-picker                                                  -108 B   (-0.1%)      -19 B   (-0.1%)
async-load-signup-steps-woocommerce-install-confirm                                     -62 B   (-0.1%)     -230 B   (-0.8%)
async-load-calypso-state-lib-automated-transfer-middleware                              -61 B   (-0.3%)     -215 B   (-3.1%)
async-load-signup-steps-domains                                                         +52 B   (+0.0%)      +32 B   (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -13 B   (-0.0%)      +45 B   (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

ellatrix
ellatrix approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, same as the wp-admin button 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@scruffian scruffian Awaiting requested review from scruffian

@richtabor richtabor Awaiting requested review from richtabor

@Addison-Stavlo Addison-Stavlo Awaiting requested review from Addison-Stavlo

Assignees

@youknowriad youknowriad

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add “Launch site” button to the Calypso master bar on a single site
3 participants
@youknowriad @matticbot @ellatrix