Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand on click missing on WordPress Editor (simple sites) #89564

Closed
ricklabsdotn8 opened this issue Apr 16, 2024 · 7 comments · Fixed by Automattic/jetpack#36914
Closed

Expand on click missing on WordPress Editor (simple sites) #89564

ricklabsdotn8 opened this issue Apr 16, 2024 · 7 comments · Fixed by Automattic/jetpack#36914
Assignees
@jeherve
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Post/Page Editor The editor for editing posts and pages. [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@ricklabsdotn8
Copy link

ricklabsdotn8 commented Apr 16, 2024 •
edited
Loading

Quick summary

Expand on Click is no longer available on the image block

Steps to reproduce

  1. Add an image block
  2. Open the link options to enable expand on click

What you expected to happen

Expand on click should be available:
image

What actually happened

Expand on click is missing:
image

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

8045684-zen
@ricklabsdotn8 ricklabsdotn8 added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Apr 16, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues labels Apr 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

  • 8045684-zen
  • 7985931-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 16, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 16, 2024 •
edited
Loading

I did a bit of testing and I can confirm that the "Expand on Click" option is no longer available:

Screenshot 2024-04-16 at 14 59 26

I compared this to a vanilla self-hosted site and the option IS there (with and without the plugin, Version 18.1.0)

Screenshot 2024-04-16 at 14 59 51

Initially, I thought this could be related to Automattic/jetpack#36565 but even after deactivating Jetpack's "Enable Carousel" option, the "Expand on Click" is still unavailable in the editor:

Screenshot 2024-04-16 at 14 56 59

@jeherve, do you think this could be related to the changes introduced in the PR above? I am worried this is an example of the concerned I expressed in this comment: Automattic/jetpack#36565 (comment).

@mrfoxtalbot mrfoxtalbot mentioned this issue Apr 16, 2024
Closed
@mrfoxtalbot mrfoxtalbot added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Apr 16, 2024
@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Apr 16, 2024
@mrfoxtalbot mrfoxtalbot added the [Feature] Post/Page Editor The editor for editing posts and pages. label Apr 16, 2024
@matticbot matticbot moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Apr 16, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 16, 2024 •
edited
Loading

As per Automattic/jetpack#36820, it looks like the removal is indeed due to Automattic/jetpack#36565 but it does not seem to work as expected.

In other words, if the "Enable Carousel" option is off, the default "Expand on Click" option should come back. Currently it does not look it is working.

@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 16, 2024 •
edited
Loading

I have more to share, @jeherve:

After some more testing, I can confirm that the feature works as expected on a Atomic and JP self-hosted sites. The "Expand on Click" in there by default even if JP is active and it goes away as soon as I activate the "Enable Carousel" feature.

The issue seems to be affecting only simple sites, where deactivating the option under Settings > Media does NOT re-introduce the "Expand on Click" option

@kspilarski
Copy link

This is also being discussed here - WordPress/gutenberg#56053 (comment)

I've tried several classic and FSE themes on both simple and atomic sites. Expand on click is missing.

User case 7985931-zen.

@jeherve
Copy link
Member

jeherve commented Apr 16, 2024

Yeah, that's on me. I failed to consider the toggle available in WordPress.com Simple site settings. I'll push a PR to get this fixed in a bit.

@jeherve
Copy link
Member

jeherve commented Apr 16, 2024

This is also being discussed here - WordPress/gutenberg#56053 (comment)

Since this is a WordPress.com-related issue, I would recommend keeping the conversation here.

@jeherve jeherve self-assigned this Apr 16, 2024
@mrfoxtalbot mrfoxtalbot changed the title Expand on click missing on WordPress Editor. Expand on click missing on WordPress Editor (simple sites) Apr 16, 2024
jeherve added a commit to Automattic/jetpack that referenced this issue Apr 16, 2024
@jeherve
Carousel / Lightbox: take wpcom simple shortcircuit into account
8232613 
Fixes Automattic/wp-calypso#89564

Follow-up to #36565

This is a second take on #36565; we need to ensure that when one disables the Carousel feature on their wpcom simple site, we do not remove Core's Lightbox feature.
@jeherve jeherve mentioned this issue Apr 16, 2024
Merged
3 tasks
jeherve added a commit to Automattic/jetpack that referenced this issue Apr 17, 2024
@jeherve
Carousel / Lightbox: take wpcom simple shortcircuit into account (#36914
6dd4d98 
)

Fixes Automattic/wp-calypso#89564

Follow-up to #36565

This is a second take on #36565; we need to ensure that when one disables the Carousel feature on their wpcom simple site, we do not remove Core's Lightbox feature.
matticbot pushed a commit to Automattic/jetpack-storybook that referenced this issue Apr 17, 2024
@jeherve @matticbot
Carousel / Lightbox: take wpcom simple shortcircuit into account (#36…
2f282f0 
…914)

Fixes Automattic/wp-calypso#89564

Follow-up to #36565

This is a second take on #36565; we need to ensure that when one disables the Carousel feature on their wpcom simple site, we do not remove Core's Lightbox feature.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/8720831825

Upstream-Ref: Automattic/jetpack@6dd4d98
matticbot pushed a commit to Automattic/jetpack-production that referenced this issue Apr 17, 2024
@jeherve @matticbot
Carousel / Lightbox: take wpcom simple shortcircuit into account (#36…
b00f541 
…914)

Fixes Automattic/wp-calypso#89564

Follow-up to #36565

This is a second take on #36565; we need to ensure that when one disables the Carousel feature on their wpcom simple site, we do not remove Core's Lightbox feature.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/8720831825

Upstream-Ref: Automattic/jetpack@6dd4d98
@ClassicRKR27 ClassicRKR27 mentioned this issue Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Post/Page Editor The editor for editing posts and pages. [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Carousel / Lightbox: take wpcom simple shortcircuit into account Automattic/jetpack
4 participants
@jeherve @mrfoxtalbot @kspilarski @ricklabsdotn8