Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a home page template on the fly after the user finishes PA flow #69015

Closed
arthur791004 opened this issue Oct 13, 2022 · 4 comments
Closed

Create a home page template on the fly after the user finishes PA flow #69015

arthur791004 opened this issue Oct 13, 2022 · 4 comments
Assignees
@fushar
Labels
[Pri] High Address as soon as possible after BLOCKER issues

Comments

@arthur791004
Copy link
Contributor

arthur791004 commented Oct 13, 2022 •
edited
Loading

Referring to p1665497100719849/1665152933.113869-slack-CRWCHQGUB, the new blank canvas won't have a built-in home.html and we need to create it on the fly
@arthur791004 arthur791004 added the [Pri] High Address as soon as possible after BLOCKER issues label Oct 13, 2022
@fushar
Copy link
Contributor

fushar commented Oct 14, 2022

Is this basically your PR? 😄 #68473 (just need to modify the template name)

@Automattic/ganon

@arthur791004
Copy link
Contributor Author

Yes but we also need to modify the main content. Additionally, we might need to update the show_on_front option as you mentioned before

@fushar
Copy link
Contributor

fushar commented Oct 14, 2022

Okay, let me take this issue :)

@fushar fushar self-assigned this Oct 14, 2022
@fushar fushar mentioned this issue Oct 19, 2022
Merged
5 tasks
@fushar
Copy link
Contributor

fushar commented Oct 24, 2022

Landed!

@fushar fushar closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fushar fushar

Labels
[Pri] High Address as soon as possible after BLOCKER issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fushar @arthur791004