Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Tour showing behind "Your first post is published" modal #57702

Closed
autumnfjeld opened this issue Nov 5, 2021 · 6 comments
Closed

Welcome Tour showing behind "Your first post is published" modal #57702

autumnfjeld opened this issue Nov 5, 2021 · 6 comments
Assignees
Labels
Blogger Experience Pod [Pri] High Address as soon as possible after BLOCKER issues

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Nov 5, 2021

Description

In new Blogger/Write flow: Welcome Tour appeared

image

Steps to reproduce

  • Go through Blogger Flow from intent screen:
  • click write >
  • Blog name >
  • Draft First post >
  • Land in editor >
  • Write stuff in the editor >
  • click Publish >
  • NOTE: The "first post is published" modal appears and immediately after so does the Welcome Tour

What I expected to happen

To see only the "Your first post is published" modal and NOT the Welcome Tour

What happened

I saw both the "Your first post is published" modal AND the Welcome Tour

Related

A bug reported about the Welcome Tour appearing even after dismissing it: #57660. I don't think the cause of the issue reported above and #57660 are the same, but might make sense to tackle them together.

@autumnfjeld autumnfjeld changed the title Welcome Tour showing behind "Your first post is publish" modal Welcome Tour showing behind "Your first post is published" modal Nov 5, 2021
@autumnfjeld autumnfjeld added the [Pri] High Address as soon as possible after BLOCKER issues label Nov 9, 2021
@arthur791004
Copy link
Contributor

arthur791004 commented Nov 10, 2021

Go through Blogger Flow from intent screen: click write > Blog name > Draft First post > Land in editor > Write stuff in the editor > click Publish >
The "first post is published" modal appears and immediately after so does the Welcome Tour

Hmmm...I'm not sure it's a bug or not. In this flow, the Welcome Tour shows when you land on the editor. Should we need to hide the modal after "first post is published" modal appears and show it again after "first post is published" modal is close? Or you don't see the "Welcome Tour" at the beginning and it shows suddenly after you publish the post? (But I cannot reproduce this cases)

@autumnfjeld
Copy link
Contributor Author

  • Welcome Tour should NOT show behind any of the Blogger flow modals
  • The Welcome Tour should NOT show in this blogger flow which includes: Draft post modal > writing in the editor > clicking publish > seeing the congratulations "First post modal"
  • Nice to have: The Welcome Tour could show on the 2nd time the blogger opens the editor, because in this case the modals will not show and there isn't the visual conflict. However we can make a separate issue for this, to do in the future.

If you can't reproduce the issue, we can just wait and see if anyone reports this again.

@arthur791004
Copy link
Contributor

Okay. Let's wait and see if anyone encounters this again!

@roo2
Copy link
Contributor

roo2 commented Nov 16, 2021

it looks like https://github.com/Automattic/wp-calypso/pull/57982/files is a potential fix, right @arthur791004. I couldn't reproduce it, but the theory that the iframe url was changing right after publishing sounds plausible, I think we should deploy it and then see if this keeps coming up

@arthur791004
Copy link
Contributor

Yep, it might be the potential fix. But I'm not sure it's the same situation or not.

@autumnfjeld
Copy link
Contributor Author

I'll go ahead and close this. We know to keep an eye out if it happens in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blogger Experience Pod [Pri] High Address as soon as possible after BLOCKER issues
Projects
None yet
Development

No branches or pull requests

3 participants