Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Add two Starter Designs #48381

Closed
ianstewart opened this issue Dec 15, 2020 · 10 comments · Fixed by #48727
Closed

Signup: Add two Starter Designs #48381

ianstewart opened this issue Dec 15, 2020 · 10 comments · Fixed by #48727
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Task

Comments

@ianstewart
Copy link
Contributor

ianstewart commented Dec 15, 2020

We've created two new Starter Design sites that can be added to the Design Screen in signup.

  1. https://pollardstarter.wordpress.com/
  2. https://balanstarter.wordpress.com/

There are a few themes issues surfaced by these Starter Designs that would be good to get closed before these are added to the design screen in signup.

Additionally, as these are "short" designs, they'll look their best with slightly shorter thumbnails. Something to consider for further improvements to this screen. cc @joanrho @rickybanister

Speaking of, here's what they look like right now (with those issues present) …

image

cc @iamtakashi @alaczek

Recipe

The starter design "recipe" for both sites looks like the following.

  • Mayland Theme.
  • Reduce default content to one static homepage.
  • Update block-based content in the homepage. (Expect the content here, and similar content to show up in the Editor as Patterns.)
  • Update global fonts in the Editor.
  • Set custom colour scheme and remove menu in the customizer.

These sites will not receive a blog page by default but just like a custom menu with additional pages that will be quite easy to add later.

We'll want to continue to make improvements to these Starter Designs as block-based themes are added to Signup.

@andrewserong
Copy link
Member

@ianstewart I took a look at adding these designs in #48727. I think it's currently blocked by the following two main issues:

  1. The colour styles bleeding into the editor, which I believe are already covered in the linked issues in the themes repo.
  2. The Gutenboarding layout for the design picker doesn't play nicely with short screenshots for these designs.
Balan Pollard
image image

As an aside, I love the look of these designs, though!

@p-jackson
Copy link
Member

As an aside, I love the look of these designs, though!

Same! This seems like a really useful scenario to cover in our starter designs!

@rickybanister
Copy link

Can the default width of the browser be adjusted when snapping the mshot? These are intended to be 'mobile-first' style designs and should be zoomed into the content more vs short as you show above.

@p-jackson
Copy link
Member

Can the default width of the browser be adjusted when snapping the mshot?

We can pick the browser width yes. I wonder if in that case we should also auto-select the mobile view when advancing to the next step.

Screenshot 2021-01-13 at 9 59 04 AM

That way the user isn't surprised that it looks different from what they saw in the gallery. Plus they might get a subtle clue that the layout they picked might look different on desktop.

@ianstewart
Copy link
Contributor Author

cc @ollierozdarz

@andrewserong
Copy link
Member

andrewserong commented Jan 13, 2021

Can the default width of the browser be adjusted when snapping the mshot? These are intended to be 'mobile-first' style designs and should be zoomed into the content more vs short as you show above.

That's a good point, and like Phil mentions we can set a different browser width for each screenshot if we need to. The only thing is, how would those screenshots look next to each other if some are optimised for desktop and others for mobile. I could imagine it looking a bit odd if some are more zoomed in than others.

We can definitely play around with it. If we can get a mock-up for how it should look in the Design step, that'll help us get started. I'm curious if we'll need or want more of a masonry layout like in p9Jlb4-22o-p2 ?

@ianstewart
Copy link
Contributor Author

Note: I've made an update to these two starter designs to use the new option in Varia to hide the footer and header on the homepage. No blockers and it should "just work" but if the output doesn't match the starter design because of a difference there — it doesn't "just work." :)

@lsl
Copy link
Contributor

lsl commented Feb 3, 2021

@ianstewart #48727 is ready for deploy as soon as you're ready with the remaining two issues:

@ianstewart
Copy link
Contributor Author

2918 is closed so we're just down to 2895 now.

@simison
Copy link
Member

simison commented Feb 5, 2021

2895 is closed (Automattic/themes#2895 (comment)) and will ship next week 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants