Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Premium Content block to "Earn" collection in inserter #41579

Open
artpi opened this issue Apr 29, 2020 · 6 comments
Open

Add Premium Content block to "Earn" collection in inserter #41579

artpi opened this issue Apr 29, 2020 · 6 comments
Labels
Earn Payments: before Woo A good candidate to tackle before Woo transition [Status] Blocked / Hold [Type] Task

Comments

@artpi
Copy link
Contributor

artpi commented Apr 29, 2020

There are categories and collections for blocks in the inserter. Blocks can only have one category, but they can have multiple collections.

For now, let's keep the Premium content block in the "New" Category which Ajax recently added to the block inserter.

"Earn" should be a collection, so we can also add the Premium Content block there right now.

@artpi artpi added the Earn label Apr 29, 2020
@davemart-in davemart-in changed the title Change Premium Content block category to "Earn" Add Premium Content block to "Earn" collection May 9, 2020
@eoigal eoigal self-assigned this May 11, 2020
@marekhrabe
Copy link
Contributor

marekhrabe commented May 11, 2020

Isn't "Earn" a category and not a collection? Is this issue suggesting to turn Earn from category to a collection?

Edit: just confirmed "Earn" is a category.

@davemart-in
Copy link
Contributor

Thanks for the clarification @marekhrabe!

I'm sorry, that's my bad. I thought it was a collection.

@eoigal, let's hold off on this one then. I'd like to keep the Premium Content block in the "New" category until it get's pushed out (basically, every time we manually add a new block to that category, we'll push one out so that there are only ever 6 blocks being promoted there at one time). Once Premium Content get's pushed out, we'll just reassign it to "Earn.

@jeherve
Copy link
Member

jeherve commented May 11, 2020

For reference, and if that can help, those categories were added in Automattic/jetpack#14454

@mmtr
Copy link
Member

mmtr commented May 29, 2020

I see we continue having 6 blocks in the "New" category, so I guess this is still blocked.

@gwwar
Copy link
Contributor

gwwar commented Jun 1, 2020

We'll probably have another block created next sprint, so I'll pull this back to TO DO

@davemart-in davemart-in changed the title Add Premium Content block to "Earn" collection Add Premium Content block to "Earn" collection in inserter Jun 8, 2020
@artpi artpi added the Payments: before Woo A good candidate to tackle before Woo transition label Jan 6, 2022
@dsas
Copy link
Contributor

dsas commented Jun 9, 2022

I don't think the New category exists now, but the Premium Content block is in the Grow category rather than Earn which could do with being tidied up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Earn Payments: before Woo A good candidate to tackle before Woo transition [Status] Blocked / Hold [Type] Task
Projects
None yet
Development

No branches or pull requests

9 participants