Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editor: populating our template_part header as part of site creation on WP.com [3] #33515

Closed
gwwar opened this issue May 31, 2019 · 3 comments

Comments

@gwwar
Copy link
Contributor

gwwar commented May 31, 2019

Update Note: this task is now specifically related to inserting data on WP.com during site creation. The general case of plugin usage on self-hosted WP installs will be handled in #33636.

During site creation, let's make sure our header backed by template_part is populated with the expected content. We may do this programmatically via headstart.

In order to do this while preserving our initial data representation scheme, the following should be created:

  1. wp_template_part_type taxonomy for wp_template_part CPT.
  2. wp_template_part CPT post representing the header. Let's add a Header title to this post, and assign header term to wp_template_part_type taxonomy for it.
  3. wp_template_part CPT post representing the footer. Let's add a Footer title to this post, and assign footer term to wp_template_part_type taxonomy for it.
  4. wp_template_type taxonomy for wp_template CPT.
  5. wp_template CPT representing the page template. Let's add a Page template title to this post, and assign page_template term to wp_template_type taxonomy for it.

template-parts-5

Screen Shot 2019-05-31 at 12 37 09 PM

@gwwar gwwar changed the title Full Site Editor: Populate our template_part header as part of site creation Full Site Editor: Populate our template_part header as part of site creation [8] Jun 3, 2019
@vindl vindl added this to the Cylon sprint [23-34] milestone Jun 4, 2019
@vindl vindl changed the title Full Site Editor: Populate our template_part header as part of site creation [8] Full Site Editor: Populate our template_part header as part of site creation on WP.com [8] Jun 13, 2019
@vindl vindl removed this from the Cylon sprint [23-34] milestone Jun 17, 2019
@vindl vindl changed the title Full Site Editor: Populate our template_part header as part of site creation on WP.com [8] Full Site Editor: Populate our template_part header as part of site creation on WP.com [?] Jun 17, 2019
@vindl vindl added this to the Cylon Sprint [25-26] milestone Jun 18, 2019
@vindl vindl changed the title Full Site Editor: Populate our template_part header as part of site creation on WP.com [?] Full Site Editor: Populate our template_part header as part of site creation on WP.com [5] Jun 18, 2019
@jeraldjuice jeraldjuice self-assigned this Jun 24, 2019
@kwight
Copy link
Contributor

kwight commented Jun 27, 2019

If I understand correctly, a few steps have to happen:

  • The dotcom loader needs to register the CPTs (basically, do everything that the plugin's activation hook does).
  • Set up a test annotation that we can use for development.
  • Verify Headstart's processing of the CPTs.
  • Move the CPT content into intended production annotations.

One thing to note is that Headstart does not currently support hierarchical taxonomies (this is why tags are currently supported, but categories are not). I don't believe that's important yet (we are registering hierarchical taxonomies, but I don't see us using them), but may represent some significant work down the road.

@gwwar gwwar changed the title Full Site Editor: Populate our template_part header as part of site creation on WP.com [5] Full Site Editor: Investigate populating our template_part header as part of site creation on WP.com [5] Jun 27, 2019
@gwwar gwwar changed the title Full Site Editor: Investigate populating our template_part header as part of site creation on WP.com [5] Full Site Editor: populating our template_part header as part of site creation on WP.com [5] Jul 1, 2019
@gwwar gwwar changed the title Full Site Editor: populating our template_part header as part of site creation on WP.com [5] Full Site Editor: populating our template_part header as part of site creation on WP.com [3] Jul 1, 2019
@jeraldjuice jeraldjuice removed their assignment Jul 17, 2019
@jeraldjuice
Copy link

This is on hold for now, pending the outcome of Marko's solution.

@vindl vindl self-assigned this Jul 18, 2019
@vindl
Copy link
Member

vindl commented Jul 18, 2019

Closing this for now since I've merged #34640 and Automattic/themes#1062 which should also handle it.

@vindl vindl closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants