Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNPL PMME text size on blocks and shortcode checkout #9818

Open
FangedParakeet opened this issue Nov 27, 2024 · 2 comments · May be fixed by #9925
Open

BNPL PMME text size on blocks and shortcode checkout #9818

FangedParakeet opened this issue Nov 27, 2024 · 2 comments · May be fixed by #9925
Assignees
Labels
focus: checkout payments type: enhancement The issue is a request for an enhancement.

Comments

@FangedParakeet
Copy link
Contributor

Description

This issue is a follow-up to #9488, dividing up the work comprising this issue into individual bite-sized chunks.

We would like to reduce the size of the BNPL PMME text in relation to the label title font size. Note that since both of these elements are sized dynamically, we will need to calculate the size of the payment method label and then reduce the PMME font size in relation to this element.

PMME text
PMME text in question to be altered

Acceptance criteria

I think the main problem is the text "4 interest-free payments..." is 2-3 text sizes too large, which is the main disparity from the design. If the text was smaller in scale to the PM name, the logo would appear less visually imbalanced. Can we bump the text on those lines down to 13px? (In the Figma file I'm seeing 13/16 scale for shortcode and 13/15 for blocks between the two lines).
#9488 (comment)

Limitations

Note that we should attempt to make this placement as consistent across themes as possible, but be aware that different themes control the positioning of these radio label elements very differently. If there are limitations to what we are able to achieve, please explain the limitations on this issue with the expectation that this is part of a series of incremental changes and we should try to accomplish the best experience possible within the constraint of what is feasible.

Additional context

#9488 (comment)

@FangedParakeet FangedParakeet added component: checkout Issues related to Checkout type: enhancement The issue is a request for an enhancement. focus: checkout payments status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. and removed component: checkout Issues related to Checkout labels Nov 27, 2024
@FangedParakeet
Copy link
Contributor Author

Blocked pending some related work that will be completed in #9803 (PR in #9805).

@danielmx-dev
Copy link
Contributor

I bumped this issue to the next milestone, given that it's still under review and the limited team availability in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments type: enhancement The issue is a request for an enhancement.
Projects
None yet
2 participants