You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template parts such as header, footer are not rendered because of the additional theme attribute. <!-- wp:template-part {"slug":"secondary-header","theme":"jaida"} /-->
I tried creating a blank theme using CBT and exported. It has no such attribute. Created Theme created using plugin doesn't render template parts WordPress/create-block-theme#396 to investigate further. Fixed by removing the attribute here: b47f723
A 404 pattern existed, but it is not used in 404 template. This can be resolved by saving the block as pattern.
And this 404 pattern should have not created by CBT. @beafialho Did you use a block theme (not a blank theme) as base while creating this theme?
This also the case for footer, and comments patterns. They are not used.
Related commits: f5df79304556d323e782d
Index and Archive pages has their own query definitions instead of a pattern. It's nothing wrong to have them this way. Moving them to a pattern is just an improvement. Leaving it as is.
Minor issue: empty height is set for spacer block. This could be a fix for gutenberg itself. 1f821ea
the assets such as images, screenshot can be compressed while exporting theme.
optionally, check if the assets used in theme and include only those in the exported theme.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Jaida: Add theme for review
Created by @beafialho