Searching UTF-8 Characters "太陽", "平均", "赤道", "太", "均", etc. Cause App to Crash

[marcuswisecaesar]


Usage environment:
iOS 15.2.1 iPadOS 15.2.1 macOS Monterey 12.1 latest
This bug is reproducible on iOS and macOS

Steps to reproduce the bug that causes the app to crash

1. Copy the text content from this post - https://www.astroarts.co.jp/alacarte/kiso/kiso01-j.shtml - into a new note.

2. search in Simplenote's search window with UTF-8 string
   Search keywords are "太陽", "平均", "赤道", "太", "均", etc.

These are the UTF-8 Codes:
592A 太
967D 陽
5E73 平
5747 均
8D64 赤
9053 道

Result:
When the above memo is hit in the search result and displayed on the screen, the Simpenote application crashes.
If there are multiple memos hit in the search results and the above memo is at the bottom, the app crashes when it is displayed by scrolling up.

What I expected:
To be shown the search result for: "太陽" etc.

utf-8.1.mov

[dmsnell]

Thanks for the report @marcuswisecaesar - I'm able to reliably reproduce the issue and I suspect we're cutting the post preview on a non-Unicode boundary since the note displays fine if not in the search.

cc: @jleandroperez

[dmsnell]

Noting a suspicious line:

simplenote-ios/Simplenote/Classes/Note+Properties.swift

Lines 96 to 97 in 67e8e61

	leadingLimit: Constants.excerptLeadingLimit,
	trailingLimit: Constants.excerptTrailingLimit) else {

We're using hard-coded string lengths and I'm wondering if those are cutting in between non-boundaries.

[peril-automattic]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'
🚫	Please add a feature label to this issue. e.g. 'Stats'

Generated by 🚫 dangerJS

[eshurakov]

Most likely related to #1064