Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github artifact actions to v4 #7698

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Update Github artifact actions to v4 #7698

merged 2 commits into from
Nov 5, 2024

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Oct 31, 2024 •
edited
Loading

Relates to https://github.com/Automattic/sensei-pro/issues/2603

Proposed Changes

This updates the deprecated Github artifact actions to v4, following the migration guide.

Testing Instructions

  1. CI should be passing.
  2. Make sure the generated CI build ("Plugin Build Download ") can be downloaded and working.
  3. There should be no actions deprecation notice in CI.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@m1r0 m1r0 added this to the 4.24.4 milestone Oct 31, 2024
@m1r0 m1r0 self-assigned this Oct 31, 2024
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 marked this pull request as ready for review October 31, 2024 16:53
@m1r0 m1r0 requested a review from a team October 31, 2024 16:53
@donnapep
Copy link
Collaborator

donnapep commented Nov 1, 2024 •
edited
Loading

I see this on some of the CI jobs. It seems related. Could we address this as well if it's quick?

Screenshot 2024-11-01 at 3 57 07 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Test the previous changes of this PR with WordPress Playground.

@m1r0
Copy link
Member Author

m1r0 commented Nov 4, 2024

Yep, that's a good suggestion. The node version warning was addressed by cf8e616.

donnapep
donnapep approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@m1r0 m1r0 merged commit c3dd120 into trunk Nov 5, 2024
22 checks passed
@m1r0 m1r0 deleted the update/github-artifact-actions-to-v4 branch November 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnapep donnapep donnapep approved these changes

Assignees

@m1r0 m1r0

Labels
No Changelog
Projects
None yet
Milestone
4.24.4
Development

Successfully merging this pull request may close these issues.
2 participants
@m1r0 @donnapep