-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles on Personal AB: Update assignment cache key #41383
Global Styles on Personal AB: Update assignment cache key #41383
Conversation
…e the experiment assignment
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
projects/packages/jetpack-mu-wpcom/src/features/wpcom-global-styles/index.php
Outdated
Show resolved
Hide resolved
projects/packages/jetpack-mu-wpcom/src/features/wpcom-global-styles/index.php
Outdated
Show resolved
Hide resolved
projects/packages/jetpack-mu-wpcom/src/features/wpcom-global-styles/index.php
Outdated
Show resolved
Hide resolved
projects/packages/jetpack-mu-wpcom/src/features/wpcom-global-styles/index.php
Outdated
Show resolved
Hide resolved
Do not merge until the experiment starts. |
The experiment is now live. Merging changes. |
Proposed changes:
Since the changes are already merged, users are assigned to the control group, and the assignment is cached. With these changes, we're changing the cache key so that users get re-assigned once we merge these changes
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
global-styles/status