Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles on Personal AB: Update assignment cache key #41383

Merged

Conversation

rcrdortiz
Copy link
Contributor

@rcrdortiz rcrdortiz commented Jan 29, 2025

Proposed changes:

Since the changes are already merged, users are assigned to the control group, and the assignment is cached. With these changes, we're changing the cache key so that users get re-assigned once we merge these changes

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes
  • Sandbox your API
  • Go to Calypso theme showcase (logged in)
  • Open the network tab and filter requests by global-styles/status
  • By default you should get the corresponding assignment. Change the assignment and clear the cache and you should have the new assignment group.

@rcrdortiz rcrdortiz changed the title Add/global styles on personal experiment cache if running Global Styles on Personal AB: Cache assignment group when experiment is running Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/global-styles-on-personal-experiment-cache-if-running branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/global-styles-on-personal-experiment-cache-if-running
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/store/membership-products/resolvers.js 56/106 (52.83%) 0.94% -1 💚

Full summary · PHP report · JS report

@rcrdortiz rcrdortiz requested a review from a team January 29, 2025 10:04
@rcrdortiz rcrdortiz self-assigned this Jan 29, 2025
@rcrdortiz rcrdortiz changed the title Global Styles on Personal AB: Cache assignment group when experiment is running [DO NOT MERGE] Global Styles on Personal AB: Cache assignment group when experiment is running Jan 29, 2025
@rcrdortiz rcrdortiz added the DO NOT MERGE don't merge it! label Jan 29, 2025
@rcrdortiz
Copy link
Contributor Author

Do not merge until the experiment starts.

@rcrdortiz rcrdortiz changed the title [DO NOT MERGE] Global Styles on Personal AB: Cache assignment group when experiment is running [DO NOT MERGE] Global Styles on Personal AB: Update assignment cache key Jan 29, 2025
@rcrdortiz rcrdortiz changed the title [DO NOT MERGE] Global Styles on Personal AB: Update assignment cache key Global Styles on Personal AB: Update assignment cache key Jan 29, 2025
@rcrdortiz
Copy link
Contributor Author

The experiment is now live. Merging changes.

@rcrdortiz rcrdortiz removed the DO NOT MERGE don't merge it! label Jan 29, 2025
@rcrdortiz rcrdortiz merged commit 5317231 into trunk Jan 29, 2025
62 of 64 checks passed
@rcrdortiz rcrdortiz deleted the add/global-styles-on-personal-experiment-cache-if-running branch January 29, 2025 17:22
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants