Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure binary version matches Gradle plugin version #12

Open
oguzkocer opened this issue Apr 15, 2021 · 1 comment
Open

Ensure binary version matches Gradle plugin version #12

oguzkocer opened this issue Apr 15, 2021 · 1 comment

Comments

@oguzkocer
Copy link
Contributor

We need to add a version check here to make sure we update the binary whenever the Gradle plugin is updated. Otherwise, even if the Gradle plugin version is updated in the client, it'll still use the old binary.

P.S: There might be a better place for this check, but I wanted to make sure to link this one when/if I work on this issue.

cc @jkmassel

@jkmassel
Copy link
Contributor

@oguzkocer and I chatted offline about just distributing the binaries with the gradle plugin as a resource rather than downloading it. This is a better approach, so we should do that (rather than adding a version check).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants