Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sirene is not always blinking when a build is in failed state #105

Open
TurboPablos opened this issue Nov 21, 2017 · 2 comments
Open

Sirene is not always blinking when a build is in failed state #105

TurboPablos opened this issue Nov 21, 2017 · 2 comments

Comments

@TurboPablos
Copy link

We're using Sirene of Shame connected to the VSTS and monitoring few projects builds.

When one build (project A) is in failed state, sirene is blinking for the failed build as expected. But, if after that someone has triggered next build (project B), sirene is blinking for the running build as expected as well. If the second build is successfull, sirene is not blinkinig anymore even if the first build for project A is still failed.

It would be nice to remain the Sirene behavior for the failed build if at least one build is in failed state.

@lprichar
Copy link
Member

That's a great point! I've mostly only ever watched a small numbers of builds, but I can imagine with many builds the value of the siren would go down. To do it right is a tricky concurrency problem. But perhaps an easy first step is just to remember and then restore the state of the siren when a build is triggered.

@TurboPablos
Copy link
Author

First of all- sorry for the delay, many things around to do ;)

Then I want to apreciate all your work, it was a brilliant idea to create this kind of tool like Sirene of Shame :)

What do you think, when can we expect it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants