New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider caching this x,y,z point. #1

Open

wallabyway opened this issue Apr 8, 2020 · 0 comments

wallabyway commented Apr 8, 2020 •

edited

Loading

forge-extensions/public/extensions/IconMarkupExtension/contents/main.js

Line 153 in 12e128d

    
           const pos = this.viewer.worldToClient(this.getModifiedWorldBoundingBox(id).center());

Consider caching this x,y,z point.

If it already exists, then you don't need to traverse the frag tree and calculate the union().center() every frame.

Something like this...

posCache = [];

.... 

if (!posCache[id])
	posCache[id] = this.viewer.worldToClient(this.getModifiedWorldBoundingBox(id).center());

 const pos = posCache[id];

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment