Skip to content

Commit d66733c

Browse files
committed
examples/workflow_by_code.ipynd: fix an error in R.get_recorder() parameters
get_recorder() needs specify 'recorder_id='. However workflow_by_code.ipynd didn't. This patch fixes it. Without this fix, here is the error message jupyter-notebook reports: "--------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-7-e6a7b5f4da00> in <module> 26 # backtest and analysis 27 with R.start(experiment_name="backtest_analysis"): ---> 28 recorder = R.get_recorder(rid, experiment_name="train_model") 29 model = recorder.load_object("trained_model") 30 TypeError: get_recorder() takes 1 positional argument but 2 positional arguments (and 1 keyword-only argument) were given" Signed-off-by: Guodong Xu <[email protected]>
1 parent 9cf574b commit d66733c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

examples/workflow_by_code.ipynb

+2-2
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@
220220
"\n",
221221
"# backtest and analysis\n",
222222
"with R.start(experiment_name=\"backtest_analysis\"):\n",
223-
" recorder = R.get_recorder(rid, experiment_name=\"train_model\")\n",
223+
" recorder = R.get_recorder(recorder_id=rid, experiment_name=\"train_model\")\n",
224224
" model = recorder.load_object(\"trained_model\")\n",
225225
"\n",
226226
" # prediction\n",
@@ -249,7 +249,7 @@
249249
"source": [
250250
"from qlib.contrib.report import analysis_model, analysis_position\n",
251251
"from qlib.data import D\n",
252-
"recorder = R.get_recorder(ba_rid, experiment_name=\"backtest_analysis\")\n",
252+
"recorder = R.get_recorder(recorder_id=ba_rid, experiment_name=\"backtest_analysis\")\n",
253253
"pred_df = recorder.load_object(\"pred.pkl\")\n",
254254
"pred_df_dates = pred_df.index.get_level_values(level='datetime')\n",
255255
"report_normal_df = recorder.load_object(\"portfolio_analysis/report_normal.pkl\")\n",

0 commit comments

Comments
 (0)