Skip to content

Split out Authenticator's constructor "path" parameter into "clientHost" and "clientPath" #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
g105b opened this issue Mar 12, 2020 · 0 comments · Fixed by #3
Closed

Comments

@g105b
Copy link
Member

g105b commented Mar 12, 2020

This has caught me out more than once while building Authwave. I see currentPath, so I provide it with $this->server->getRequestUri(), but the provider actually requires the host too, to load the correct settings on the provider's database. This could be fixed by changing the name of the parameter to indicate that the full path with host is required, but would be cleaner to provide it as two parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant