Test login redirects to localhost on http

Author: Greg Bowler

src/AuthUri.php

@@ -40,10 +40,13 @@ private function normaliseBaseUri(string $baseUri):Uri {
 			?? "https";
 		$host = parse_url($baseUri, PHP_URL_HOST)
 			?? parse_url($baseUri, PHP_URL_PATH);
+		$port = parse_url($baseUri, PHP_URL_PORT)
+			?? 80;
 
 		$uri = (new Uri())
 			->withScheme($scheme)
-			->withHost($host);
+			->withHost($host)
+			->withPort($port);
 
 		if($uri->getHost() !== "localhost"
 		&& $uri->getScheme() !== "https") {

src/Authenticator.php

@@ -62,7 +62,11 @@ public function login():void {
 		}
 
 		$token = new Token($this->clientKey, $this->clientSecret);
-		$loginUri = new AuthUri($token, $this->authwaveHost);
+		$loginUri = new AuthUri(
+			$token,
+			$this->redirectPath,
+			$this->authwaveHost
+		);
 		$this->redirectHandler->redirect($loginUri);
 	}
 

test/phpunit/AuthenticatorTest.php

@@ -89,4 +89,27 @@ public function testLoginRedirects() {
 		);
 		$sut->login();
 	}
+
+	public function testLoginRedirectsLocalhost() {
+		$_SESSION = [];
+
+		$redirectHandler = self::createMock(RedirectHandler::class);
+		$redirectHandler->expects(self::once())
+			->method("redirect")
+			->with(self::callback(fn(UriInterface $uri) =>
+				$uri->getScheme() === "http"
+				&& $uri->getHost() === "localhost"
+				&& $uri->getPort() === 8081
+			));
+
+		$sut = new Authenticator(
+			"test-key",
+			"test-secret",
+			"/",
+			"http://localhost:8081",
+			null,
+			$redirectHandler
+		);
+		$sut->login();
+	}
 }