Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Enterprise DAO creation problem #1916

Open
macor161 opened this issue Jan 23, 2020 · 12 comments
Open

Open Enterprise DAO creation problem #1916

macor161 opened this issue Jan 23, 2020 · 12 comments
Assignees
Labels

Comments

@macor161
Copy link

macor161 commented Jan 23, 2020

Describe the bug

A few users have recently reported having problems creating a new DAO with the open-enterprise template, resulting in a DAO with only the Tokens, Finance and Voting apps installed but more importantly, the app management permission set to 0xc54c5dB63aB0E79FBb9555373B969093dEb17859, which seems to be the template's smart contract. Therefore they cannot install any app to their DAO.

Is there any way for them to recover their permissions?

Mainnet or testnet?

Mainnet

Organization

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'mainnet.aragon.org'
  2. Create a new DAO based on open-enterprise template
  3. Users have reported not seeing any error in the process

Desktop (please complete the following information):

  • macOS
  • Chrome
@sohkai
Copy link

sohkai commented Jan 23, 2020

This is specifically due to their second organization creation transaction not working.

@macor161
Copy link
Author

@Quazia Any way for them to re-run the second transaction? I see that you have a DAO recovery script here, could it be useful?

@stellarmagnet
Copy link
Collaborator

Yes @sohkai is correct, this happened in December when there were gas issues, but we haven’t seen any failures lately.

We did create a script you mentioned @macor161 and there are instructions for it here, but we have it more as an internal tool (aren’t expecting someone to download our repo to use it):

https://www.notion.so/autark/DAO-Recovery-9e64e29c56884a748cbfeb1b5eccba61

If you direct them to our Keybase we can help them, otherwise let me know if this information is useful.

@macor161
Copy link
Author

@stellarmagnet Great, thanks for the doc Yalda! 🙂 I will try it out with a user and let you know how it went.

@javieralaves javieralaves added bug Something isn't working template labels Jan 24, 2020
@macor161
Copy link
Author

hmm.. it doesn't seem to work. Here is what I did to test the script:

  1. Created a new Open Enterprise DAO
  2. Cloned open-enterprise and installed dependencies
  3. Executed npm run recoverTemplate and got the following info:
    • Contract: 0xc54c5dB63aB0E79FBb9555373B969093dEb17859
    • Transaction data:0xe160b2c5000000000000000000000000000000000000000000000000016345785d8a000000000000000000000000000000000000000000000000000006f05b59d3b20000000000000000000000000000000000000000000000000000000000000001518000000000000000000000000000000000000000000000000000000000000151800000000000000000000000000000000000000000000000000000000000000000
  4. Tried to execute the transaction a few times but always failed

@stellarmagnet stellarmagnet removed the bug Something isn't working label Jan 26, 2020
@evok3d
Copy link

evok3d commented Jan 27, 2020

Hey all. I have had the same issue with my registration. The package never installed and as mentioned "the app management permission set to 0xc54c5dB63aB0E79FBb9555373B969093dEb17859", as such it is causing a lot of issues. Would appreciate some assistance to this issue that has affected several people.

@marsrobertson
Copy link

The link in the first post is not correct (marsxr not marsx):

https://mainnet.aragon.org/?#/marsxr

image

I've actually created a new DAO but it will cool to recover the previous one so that I can do various DAO to DAO turtles all the way down operations...

@topocount
Copy link
Collaborator

hmm.. it doesn't seem to work. Here is what I did to test the script:

  1. Created a new Open Enterprise DAO

  2. Cloned open-enterprise and installed dependencies

  3. Executed npm run recoverTemplate and got the following info:

    • Contract: 0xc54c5dB63aB0E79FBb9555373B969093dEb17859
    • Transaction data:0xe160b2c5000000000000000000000000000000000000000000000000016345785d8a000000000000000000000000000000000000000000000000000006f05b59d3b20000000000000000000000000000000000000000000000000000000000000001518000000000000000000000000000000000000000000000000000000000000151800000000000000000000000000000000000000000000000000000000000000000
  4. Tried to execute the transaction a few times but always failed

Hi @macor161 there are two issues with this tx. the first is that the allocations period must be at least a day in length (minimum 86400 seconds). Second it seems the gas limit is low, given other successful transactions.

The prompt for the minimum allocations period length has been updated and merged so if you pull the latest changes, it shouldn't allow an invalid parameter for allocations period to be entered going forward. Thanks for finding this issue.

It's also worth noting that the template will accept a zero value for the allocations period parameter, and default it to 30 days, but this CLI tool will not, since that's just a convention for the template onboarding UI.

@topocount
Copy link
Collaborator

topocount commented Jan 28, 2020

Hi @evok3d please provide answers to the following prompts and I'll get back to you with instructions for what to do next.

  • enter the desired dot voting period length, in seconds >
  • enter the dot voting minimum candidate support percentage >
  • enter the dot voting quorum percentage >
  • enter the allocations period duration, in days >

You are also welcome to reach out to us on keybase chat.

@topocount
Copy link
Collaborator

The link in the first post is not correct (marsxr not marsx):

https://mainnet.aragon.org/?#/marsxr

image

I've actually created a new DAO but it will cool to recover the previous one so that I can do various DAO to DAO turtles all the way down operations...

@marsrobertson if you created another dao after the dao that failed there is unfortunately no way to recover that partially deployed dao :(

@stellarmagnet stellarmagnet added this to the Offsite Hackathon milestone Jan 28, 2020
@marsrobertson
Copy link

marsrobertson commented Jan 28, 2020

I've followed up on the Keybase chat:

If you created another dao after the dao that failed there is unfortunately no way to recover that partially deployed dao :(

It's a technical limitation. We only store data for the most recently deployed dao in the cache per user address, so once another dao is deployed from the same address the state from the partially deployed dao is lost

Not mission critical, I was testing, encountered some issues, moved on... :)

I can confirm that both DAOs were created from the same account:

@evok3d
Copy link

evok3d commented Feb 7, 2020

Hi @evok3d please provide answers to the following prompts and I'll get back to you with instructions for what to do next.

* `enter the desired dot voting period length, in seconds > `

* `enter the dot voting minimum candidate support percentage > `

* `enter the dot voting quorum percentage > `

* `enter the allocations period duration, in days > `

You are also welcome to reach out to us on keybase chat.

My issue was resolved! thank you so much for all your help. I reached out to kevbot from autark on keybase and was guided through the process. Hopefully Aragon can solve the timing issue with the process, so it doesnt time out and leave the app in that state.

I also want to thank @macor161 for all the assistance, time, and patience in helping me resolve this. Great work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants