-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear Stale GitHub Token from cache #654
Comments
@Schwartz10 Is this issue related to what just happened to me here? I revoked GitHub, refreshed the app, and it basically became unusable until I cleared the cache. |
@jayalaves it's been a while since I was in this part of the code, but it smells like the same issue. The app should remove the token from cache automatically if it attempts to log in to your github and comes back with a |
I was able to reproduce this by following @Schwartz10's instructions. The Projects app becomes unusable until you clear cache, after which the user is logged out. @javieralaves What should happen in this scenario? I suppose simply log the user out immediately? Maybe an error message? |
Ok. There are actually several places that need checking - each time a GH query errors out with networkError 401 we need to show a 'log in again' button with appropriate message, like "you have been kicked out of GH, please log ing again". Places:
I tried clearing @javieralaves when you have a spare moment... :) |
Yalda Update: Can someone try to test & reproduce this. If not reproducible then close it.
The app is using a stale github token, so we get a bunch of errors when trying to fetch repos and issues
The app needs to handle a 403 error (or whatever it comes back as) from github and clear the aragon cache's github token
The text was updated successfully, but these errors were encountered: