Add container scanner step #12
Draft
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits up the build and push steps and adds a container scan step before push. This allows container scans to block policy violating images from being pushed.
Change impacts I am aware of:
About 3 dozen repositories disable caching of the containers. This will cause a second container build as during second docker step where we perform the push it will not be able to leverage cache. I do not know why caching is disabled for those repositories but if we could enable caching that will save runner minutes.
If any containers are currently being built that wouldn't pass the policy (patchable critical/high vulnerabilities older than 30 days) this will block pushes.