Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Integrate Codecov #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrate Codecov #33

wants to merge 2 commits into from

Conversation

AtilioA
Copy link
Owner

@AtilioA AtilioA commented May 18, 2022

Creates a coverage.yml file with instructions to run tests and upload coverage results with GitHub Actions.
Will wait for #27 to be solved first to avoid unnecessary workflow failures.
Closes #31.

@AtilioA AtilioA self-assigned this May 20, 2022
@AtilioA AtilioA added tests This issue or PR is related to automated tests enhancement New feature or request on-hold This issue or PR is waiting for something labels May 20, 2022
@AtilioA AtilioA linked an issue May 20, 2022 that may be closed by this pull request
@AtilioA AtilioA mentioned this pull request May 24, 2022
@Henriquelay
Copy link
Collaborator

Henriquelay commented May 24, 2022

As discussed in #42, we need to know Codecov's parameter to set working directory to server and web, separetely, just like I did in run actions, since the repo is not a single project

@AtilioA
Copy link
Owner Author

AtilioA commented May 24, 2022

This seems to be exactly what we're looking for, but I don't know if we can use this with Actions: https://docs.codecov.com/docs/flags

@AtilioA AtilioA removed the on-hold This issue or PR is waiting for something label Jun 15, 2022
@Henriquelay
Copy link
Collaborator

Can we work on merging this asap?

@Henriquelay Henriquelay marked this pull request as ready for review August 10, 2022 05:22
@Henriquelay
Copy link
Collaborator

Henriquelay commented Aug 10, 2022

I've marked as ready for review to try to re-run the actions, but

Only able to re-run a workflow ran within a month.
Any workflow ran on more than 30 days cannot be re-run

Can you rebase (to trigger auto complete, should just fast-forward) and then merge? So we don't push a failing CI to trunk

AtilioA and others added 2 commits August 10, 2022 09:38
Codecov remains completely untested, since we need tests first
@AtilioA AtilioA force-pushed the integrate-codecov branch from e978f30 to df502e3 Compare August 10, 2022 12:38
@AtilioA
Copy link
Owner Author

AtilioA commented Aug 10, 2022

Lots of undefined :(

@Henriquelay
Copy link
Collaborator

Henriquelay commented Aug 11, 2022

It's failing because of missing dotfiles...

Base automatically changed from develop to master August 11, 2022 12:48
@AtilioA
Copy link
Owner Author

AtilioA commented Aug 11, 2022

f...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request tests This issue or PR is related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate CodeCov (CI)
2 participants