ScopeSimple #426
Merged
ScopeSimple #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutoburg
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 76.53% 76.59% +0.05%
==========================================
Files 65 66 +1
Lines 7970 8091 +121
==========================================
+ Hits 6100 6197 +97
- Misses 1870 1894 +24 ☔ View full report in Codecov by Sentry. |
|
Closes #388 |
teutoburg
force-pushed
the
scopesimple-1
branch
3 times, most recently
from
34794a6
to
f412f5b
Compare
Include modes argument Plot improvements Typing, docstrings, reprs Don't pass [None], just None Download missing packages Pass initial dit & ndit = None, this is an IRDB problem... Allow slice and kwargs for plot Improve plot method Add optional readout method Move download functionality to the right module Refactoring, docstrings and cleanup Increase coverage
Catch case of no DIT or NDIT to avoid weird error Improve handling of MINDIT Pass kwargs to detector effects These now pass
teutoburg
force-pushed
the
scopesimple-1
branch
from
f412f5b
to
0f1f4dd
Compare
|
This is not fully functional yet, mostly because of #464. I'd still suggest merging this PR, as it passes now, to avoid this getting further out of sync, and then fully implementing it once the DIT/NDIT stuff is properly fixed... |
hugobuddel
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New top-level User Interface, as presented at the METIS Science Team Meeting.