Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async backing migrations #1343

Merged
merged 19 commits into from
Sep 8, 2024
Merged

async backing migrations #1343

merged 19 commits into from
Sep 8, 2024

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Aug 28, 2024

Pull Request Summary

Multi-block migrations for pallet-vesting
Enable async backing on shibuya and adjust parameters
OnTimestampSet to Aura to validate timestamp based on slot

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.
  • dapp-staking unlocking migrations

@ermalkaleci ermalkaleci changed the title vesting mbm async backing migrations Aug 28, 2024
@ermalkaleci ermalkaleci added the runtime This PR/Issue is related to the topic “runtime”. label Aug 28, 2024
@ermalkaleci
Copy link
Contributor Author

/bench shibuya-dev vesting_mbm

Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10603441103.
Please wait for a while.
Branch: feat/async-backing-migrations
SHA: 12e337a

Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10603441103.

@ermalkaleci ermalkaleci marked this pull request as ready for review September 3, 2024 06:43
@ermalkaleci
Copy link
Contributor Author

/bench shibuya-dev pallet-dapp-staking

@ermalkaleci
Copy link
Contributor Author

/bench shibuya-dev pallet-dapp-staking

Copy link

github-actions bot commented Sep 3, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10684800692.
Please wait for a while.
Branch: feat/async-backing-migrations
SHA: d308490

Copy link

github-actions bot commented Sep 3, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10684800692.

pallets/dapp-staking/src/migration.rs Show resolved Hide resolved
pallets/dapp-staking/src/migration.rs Show resolved Hide resolved
pallets/vesting-mbm/src/lib.rs Show resolved Hide resolved
pallets/vesting-mbm/src/mock.rs Show resolved Hide resolved
runtime/shibuya/src/lib.rs Show resolved Hide resolved
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pallet_inflation needs to be updated to account for the InflationConfiguration DB entry with _per_block values. These should be halved.
  • pallet_price_aggregator has ValueAggregator value with limit_block value which should be updated
  • dapp_staking needs more updates:
    • ProtocolState's next_era_start needs to be updated
    • InflationCycleConfig struct in Shibuya runtime is related to the next_era_start

Copy link

github-actions bot commented Sep 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking/src/test 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
primitives/src 57% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/dapp-staking/src 90% 0%
pallets/collator-selection/src 92% 0%
pallets/inflation/src 89% 0%
pallets/vesting-mbm/src 89% 0%
pallets/ethereum-checked/src 74% 0%
pallets/static-price-provider/src 85% 0%
precompiles/unified-accounts/src 100% 0%
pallets/dapp-staking/src 83% 0%
primitives/src/xcm 65% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/collective-proxy/src 86% 0%
pallets/unified-accounts/src 86% 0%
precompiles/dapp-staking/src/test 0% 0%
precompiles/assets-erc20/src 78% 0%
precompiles/sr25519/src 64% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/price-aggregator/src 82% 0%
pallets/xc-asset-config/src 50% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/substrate-ecdsa/src 74% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
precompiles/xcm/src 71% 0%
Summary 79% (3726 / 4730) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor questions

pallets/dapp-staking/src/migration.rs Show resolved Hide resolved
pallets/dapp-staking/src/migration.rs Show resolved Hide resolved
pallets/dapp-staking/src/benchmarking/mod.rs Show resolved Hide resolved
@ipapandinas
Copy link
Contributor

  • pallet_price_aggregator has ValueAggregator value with limit_block value which should be updated

@ermalkaleci I am not seeing this, are you going to do it later?

@ermalkaleci
Copy link
Contributor Author

  • pallet_price_aggregator has ValueAggregator value with limit_block value which should be updated

@ermalkaleci I am not seeing this, are you going to do it later?

It isn't that important. We decided to skip it

@Naoufum101
Copy link

/bench shibuya-dev pallet-dapp-staking

@ermalkaleci ermalkaleci merged commit 6a6e767 into master Sep 8, 2024
8 checks passed
@ermalkaleci ermalkaleci deleted the feat/async-backing-migrations branch September 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants