Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp Staking v3 - Legacy Ledger Support #1120

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jan 2, 2024

Pull Request Summary

Adds legacy wrapper into dApp staking v3 to support two dApps staking v2 calls:

  • unbond_and_unstake
  • withdraw_from_unregistered

This will allow users of the legacy Astar Native Ledger app to withdraw their funds after the v3 launch.

From the Ledger app:

#define PD_CALL_DAPPSSTAKING_UNBOND_AND_UNSTAKE_V2 4
typedef struct {
    pd_SmartContract_t contract_id;
    pd_Compactu128_t amount;
} pd_dappsstaking_unbond_and_unstake_V2_t;

#define PD_CALL_DAPPSSTAKING_WITHDRAW_UNBONDED_V2 5
typedef struct {
} pd_dappsstaking_withdraw_unbonded_V2_t;

@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Jan 2, 2024
Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the wrappers? Just a simple one reused from unlock/claim test would be fine just to make sure it works as expected in future as well.

@Dinonard
Copy link
Member Author

Dinonard commented Jan 3, 2024

Can you add tests for the wrappers? Just a simple one reused from unlock/claim test would be fine just to make sure it works as expected in future as well.

Of course, not sure how I missed this 😁

Copy link

github-actions bot commented Jan 3, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/inflation/src 70% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/xvm/src 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/xcm/src 72% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking-migration/src 39% 0%
primitives/src 66% 0%
pallets/ethereum-checked/src 48% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/collator-selection/src 69% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/unified-accounts/src 84% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/xvm/src 74% 0%
primitives/src/xcm 66% 0%
pallets/xc-asset-config/src 53% 0%
pallets/dapps-staking/src 81% 0%
pallets/dapp-staking-v3/src/benchmarking 0% 0%
pallets/dapp-staking-v3/src 78% 0%
pallets/xvm/src 40% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/dapps-staking/src 94% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/assets/src 0% 0%
pallets/block-rewards-hybrid/src 87% 0%
Summary 68% (3181 / 4706) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit 1fa3c7b into master Jan 3, 2024
9 checks passed
@Dinonard Dinonard deleted the feat/ds-v3-legacy-ledger-support branch January 3, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants