Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do away with configure-aspen.py #373

Closed
chadwhitacre opened this issue Aug 5, 2014 · 5 comments · Fixed by #381
Closed

do away with configure-aspen.py #373

chadwhitacre opened this issue Aug 5, 2014 · 5 comments · Fixed by #381

Comments

@chadwhitacre
Copy link
Contributor

Now that we're a framework and not an app server, we don't need a special way to exec python code to configure your site. Just use Python! This means that if want to use Python to configure your site you'll need to unroll one of the following, depending on your deployment scenario:

  • aspen/wsgi.py
  • aspen/__main__.py
  • fcgi_aspen.py

call

@chadwhitacre chadwhitacre mentioned this issue Aug 5, 2014
36 tasks
@pjz
Copy link
Contributor

pjz commented Aug 5, 2014

So we need to:

  • change the aspen/configuration code to not do eval configure-aspen.py
  • put the first comment here somewhere in the docs for configuration as a HOWTO

@chadwhitacre
Copy link
Contributor Author

IRC

@pjz
Copy link
Contributor

pjz commented Jun 19, 2015

Query: If we do this, do we still need a project_root at all? or can we run just given a www_root ?

@chadwhitacre
Copy link
Contributor Author

[C]an we run just given a www_root?

Worth considering. Even if we scrap sys.path modifications, you'd still get cwd on sys.path for the python -m aspen case. Not sure about behavior under gunicorn, etc. For heavier-duty setups you're installing proper modules in a virtualenv anyway.

We do resolve templates bases/includes with project_dir in aspen-jinja2. What would we do there?

Error simplates we've talked about: #141.

@pjz
Copy link
Contributor

pjz commented Jun 21, 2015

Add a knob to aspen-jinja2 to set that; or do all templating systems have a template base, so we should make a generic template_root for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants