Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow superclasses in json encoder registry #285

Open
chadwhitacre opened this issue Jan 29, 2014 · 0 comments
Open

allow superclasses in json encoder registry #285

chadwhitacre opened this issue Jan 29, 2014 · 0 comments
Labels
Core Simplate bug/feature

Comments

@chadwhitacre
Copy link
Contributor

@simon-weber in IRC:

I was thrown off that register_encoder did a check against the specific class, rather than an isinstance check
is this deliberate?
it doesn't allow for defining a common encoder in a superclass, which seems a really natural thing to do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Simplate bug/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjz @chadwhitacre